Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: Fix reliableTrDimensions test for initially hidden iframes (3.x) #5359

Merged
merged 1 commit into from Nov 6, 2023
Merged

CSS: Fix reliableTrDimensions test for initially hidden iframes (3.x) #5359

merged 1 commit into from Nov 6, 2023

Conversation

mgol
Copy link
Member

@mgol mgol commented Nov 3, 2023

Summary

Followup to gh-5317 - that PR didn't apply to the reliableTrDimensions support test.

Also, account for the fact old Firefox (<61) has null computed style for elements in such iframes.

main version of this PR: #5358

Checklist

@mgol
CSS: Fix reliableTrDimensions test for initially hidden iframes (3.x)
49ffd4c 
Also, account for the fact old Firefox (<61) has `null` computed style
for elements in such iframes.

Ref jquerygh-5317
@mgol mgol mentioned this pull request Nov 3, 2023
Merged
1 task
@mgol mgol self-assigned this Nov 3, 2023
@mgol mgol added CSS Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Nov 3, 2023
@mgol mgol added this to the 3.7.2 milestone Nov 3, 2023
@mgol mgol mentioned this pull request Nov 3, 2023
Merged
2 tasks
@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Nov 6, 2023
@mgol mgol merged commit 4e98980 into jquery:3.x-stable Nov 6, 2023
6 of 11 checks passed
@mgol mgol deleted the 3.x-reliableTrDimensions-fix branch November 6, 2023 23:35
mgol added a commit that referenced this pull request Nov 6, 2023
@mgol
CSS: Fix reliableTrDimensions support test for initially hidden iframes
b1e66a5 
Closes gh-5358
Ref gh-5317
Ref gh-5359
mgol added a commit that referenced this pull request Nov 13, 2023
@mgol
Tests: Workaround a tr width test issue in old iOS
b5b43ad 
Old iOS (<10) always rounds widths down, account for this in tests.

Closes gh-5361
Ref gh-5317
Ref gh-5359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels
CSS
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgol @timmywil