Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: remove scripts and dev deps from dist package.json #5404

Merged
merged 2 commits into from Feb 5, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Feb 5, 2024

  • this became necessary due to the addition of the prepare script
  • scripts aren't needed and don't work in the dist repo

Summary

Hit this snag on the last step testing npm publish in the dist repo, which tried to run the new prepare script, which of course failed.

Checklist

- this became necessary due to the addition of the prepare script
- scripts aren't needed and don't work in the dist repo
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one comment request.

build/release/dist.js Show resolved Hide resolved
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@timmywil timmywil merged commit 7eac932 into jquery:main Feb 5, 2024
13 checks passed
@timmywil timmywil deleted the package branch February 5, 2024 15:36
@timmywil timmywil added this to the 4.0.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants