fallback to elem.style for disconnected nodes, fixes #10254 and #8388 #553
Conversation
| @@ -290,6 +290,10 @@ if ( document.documentElement.currentStyle ) { | |||
| rsLeft = elem.runtimeStyle && elem.runtimeStyle[ name ], | |||
| style = elem.style; | |||
|
|
|||
| if ( !ret && style ) { | |||
There was a problem hiding this comment.
it's ok if ret is 0 here right? maybe this should be ret === undefined
There was a problem hiding this comment.
hmmm... maybe. I'm not sure it's undef... we may also want to be checking empty strings and null as well. checking for 0 is a perf. optimization... so I'm not 100% sure it'll work in all cases.
There was a problem hiding this comment.
I don't think we should check for null and I really don't think we need to check for 0. Getting a null value would only occur when the specific style does not exist on currentStyle, in which case it should return null. And 0 can be a valid computed value that should not be changed.
There was a problem hiding this comment.
OK, so just check for undef it is... I'll make sure the unit test passes here. Thanks!
There was a problem hiding this comment.
@timmywil, i just tested this. IE8 returns null in my unit tests... i need to check for null/undefined for disconnected nodes! i can get rid of the 0 check though, i think.
There was a problem hiding this comment.
It's returning null for a non-existent property? I guess the property exists, but IE chooses to return null on disconnected nodes?
There was a problem hiding this comment.
Ok, then just a check for null should be sufficient. When you said "don't have currentStyle", I assumed the property was non-existent.
There was a problem hiding this comment.
it returns null for the currentStyle property, and the right value in elem.style for background-image and top.
|
Landed in commit e502012. |
…es in width/height retrieval. Fixes #8388. More Details: - jquery#553 - http://bugs.jquery.com/ticket/10254 - http://bugs.jquery.com/ticket/8388
disconnected nodes don't have currentStyle in IE<9!