New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Update devDependencies & jsHint configuration #259
Conversation
It's a good practice to list peerDependencies directly in package.json, especially that current auto-installing behavior will go away in future versions of npm: npm/npm#5080 Also, jsHint plugin should search for proper .jshintrc files on its own; current behavior integrated badly with IDEs in some cases.
And also we would update deps, great :-).
nice, hate peerDeps
A bit worrisome, but i don't use them, so it's okay with me. New |
This is because IDEs/editors usually defer to the default jsHint behavior, i.e. looking for
We already duplicate a lot. Current jsHint allows to remove the duplication but not all editors have caught up yet; see jquery/jquery#1471; there was also discussion on our mailing list, @scottgonzalez was against using the |
Edit: sorry, wrong thread |
This is the WebStorm bug that makes it impossible to use it with jsHint extends option: |
Yep, i remember, that is why i said "a good way" |
"karma-browserstack-launcher": "0.0.8", | ||
"karma-chrome-launcher": "0.1.3", | ||
"karma-firefox-launcher": "0.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two are technically not needed but with them one can test locally. I didn't add Safari or IE because they're not available on all 3 platforms.
I also didn't add the Opera launcher as it's still for the old Presto version, it's extremely slow and we're in the maintenance mode for Presto Opera anyway.
👍 |
It's a good practice to list peerDependencies directly in package.json,
especially that current auto-installing behavior will go away in future
versions of npm: npm/npm#5080
Also, jsHint plugin should search for proper .jshintrc files on its own;
current behavior integrated badly with IDEs in some cases.
cc @markelog