Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip.dynamic.js: variable leaks into global scope #563

Closed
tbasse opened this issue Nov 14, 2011 · 4 comments
Closed

tooltip.dynamic.js: variable leaks into global scope #563

tbasse opened this issue Nov 14, 2011 · 4 comments

Comments

@tbasse
Copy link

tbasse commented Nov 14, 2011

https://github.com/jquerytools/jquerytools/blob/master/src/tooltip/tooltip.dynamic.js#L147

ret is not defined in current scope.

@alibby251
Copy link
Contributor

I've checked through the code - the ret variable is not defined in the scope, so this needs to be checked. Marked as High priority, as it is bad coding not to declare the variable; I've checked through the rest of the code for tooltip, and cannot see it being declared anywhere else?

@ghost ghost assigned alibby251 Feb 27, 2012
@ghost ghost assigned duclet Mar 17, 2012
@duclet
Copy link

duclet commented Mar 17, 2012

This is an easy enough fix. I'll take care of it though I'm pushing this to 1.2.8 since we are already past the deadline for 1.2.7.

@alibby251
Copy link
Contributor

Hi Duc,

Thanks - this is fine.

Alex.

On 17/03/2012 22:09, Duc Tri Le wrote:

This is an easy enough fix. I'll take care of it though I'm pushing this to 1.2.8 since we are already past the deadline for 1.2.7.


Reply to this email directly or view it on GitHub:
#563 (comment)

__________ Information from ESET NOD32 Antivirus, version of virus signature database 6975 (20120317) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com

duclet pushed a commit that referenced this issue Mar 21, 2012
@duclet
Copy link

duclet commented Mar 21, 2012

Merged into dev for 1.2.8.

@duclet duclet closed this as completed Mar 21, 2012
halfbaked pushed a commit to halfbaked/jquerytools that referenced this issue Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants