You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The dev version of RangeInput, which will become 1.2.8, works with jQuery 1.9.1 as long as the jQuery migrate plugin is used; use of the migrate plugin has revealed this warning:
"JQMIGRATE: Use of jQuery.fn.data('events') is deprecated
Cause: Prior to 1.9, .data("events") could be used to retrieve jQuery's undocumented internal event data structure for an element if no other code had defined a data element with the name "events". This special case has been removed in 1.9.
Solution: There is no public interface to retrieve this internal data structure, and it remains undocumented. The only useful applications might be for debugging. The data is available via jQuery._data("events") but this is not a documented interface."
From what I can see in the code, it seems to be at lines 134-137 in RangeInput, that causes this issue:
function hasEvent(el) {
var e = el.data("events");
return e && e.onSlide;
}
For the moment, I've created updated demos, that contain patched versions of RangeInput which include the functionality removed as part of jQuery 1.9.1 - they are:
Although the above all appear to work OK, and don't flag up the warnings, it would be good to update the code to include a more permanent/better fix for the jQuery.fn.data('events') is deprecated warning.
Please feel free to try them out - any comments/issues with compatibility with jQuery 1.9.1, please post here.
I've completed initial tests on the above in IE, Firefox, Opera and Safari - so far, all have them have tested OK with the changes required to ensure compatibility with jQuery 1.9.1. As I haven't seen any reports of issues with the changes made in the above demos, then I will be looking to commit those changes to source, and push the dev version of jQuery Tools into what will be Tools 1.2.8.
The dev version of RangeInput, which will become 1.2.8, works with jQuery 1.9.1 as long as the jQuery migrate plugin is used; use of the migrate plugin has revealed this warning:
Use of jQuery.fn.data('events') is deprecated
A check at https://github.com/jquery/jquery-migrate/blob/master/warnings.md shows this:
"JQMIGRATE: Use of jQuery.fn.data('events') is deprecated
Cause: Prior to 1.9, .data("events") could be used to retrieve jQuery's undocumented internal event data structure for an element if no other code had defined a data element with the name "events". This special case has been removed in 1.9.
Solution: There is no public interface to retrieve this internal data structure, and it remains undocumented. The only useful applications might be for debugging. The data is available via jQuery._data("events") but this is not a documented interface."
From what I can see in the code, it seems to be at lines 134-137 in RangeInput, that causes this issue:
Any solutions/suggestions welcome...
FYI - I think this was the bug report relating to the above deprecation: http://bugs.jquery.com/ticket/10589...
The text was updated successfully, but these errors were encountered: