IRC server password support

[researcx]

This adds support for IRC server passwords to Pyborg and a "password" field under the [server] section of the config file.

Originally added this for myself so I could connect Pyborg to a ZNC instance (IRC bouncer).

[jrabbit]

Thanks for the PR. The testsuite shouldn't fail. You're not handling the non-configured/fallthrough case which seems to be the main error. Use .get() potentially or look before you leap on it. You can run the test suite locally very easily with any runner (I like and bundle green)

[codecov]

Codecov Report

Merging #119 into dev will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##              dev     #119   +/-   ##
=======================================
  Coverage   46.94%   46.95%           
=======================================
  Files          20       20           
  Lines        2343     2345    +2     
=======================================
+ Hits         1100     1101    +1     
- Misses       1243     1244    +1     

Impacted Files	Coverage Δ
pyborg/pyborg/mod/mod_irc.py	57.25% <60.00%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8676373...4fc0f7c. Read the comment docs.

[jrabbit]

Thanks, I'll check it out and merge soon.

…

On Mon, Apr 27, 2020, 05:36 codecov[bot] ***@***.***> wrote: Codecov <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119?src=pr&el=h1> Report Merging #119 <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119?src=pr&el=desc> into dev <https://codecov.io/gh/jrabbit/pyborg-1up/commit/8676373e9ee9585fe475d4daba5b3d3a26224af6&el=desc> will *increase* coverage by 0.00%. The diff coverage is 60.00%. [image: Impacted file tree graph] <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119?src=pr&el=tree> @@ Coverage Diff @@ ## dev #119 +/- ## ======================================= Coverage 46.94% 46.95% ======================================= Files 20 20 Lines 2343 2345 +2 ======================================= + Hits 1100 1101 +1 - Misses 1243 1244 +1 Impacted Files <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119?src=pr&el=tree> Coverage Δ pyborg/pyborg/mod/mod_irc.py <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9tb2QvbW9kX2lyYy5weQ==> 57.25% <60.00%> (-0.12%) ⬇️ ------------------------------ Continue to review full report at Codecov <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119?src=pr&el=continue>. *Legend* - Click here to learn more <https://docs.codecov.io/docs/codecov-delta> Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119?src=pr&el=footer>. Last update 8676373...4fc0f7c <https://codecov.io/gh/jrabbit/pyborg-1up/pull/119?src=pr&el=lastupdated>. Read the comment docs <https://docs.codecov.io/docs/pull-request-comments> . — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABLU45EIBV32XW6U5SMB5TROVGZTANCNFSM4MNFX4LQ> .