completing-read gfm code languages #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 3, 2016 13:38
add defconst markdown-gfm-recognized-languages, generated from scripts/scripts/get-recognized-gfm-languages
add defcustoms for insertion of additional languages, and use linguist-recognized languages, along with user-specified options, to provide a list of languages to completing-read
cosmicexplorer
changed the title
|
Fantastic—thanks for working on this. I don't have any performance issues on my end (nor do I use helm). Looks great to me so far. I will test it a bit more before merging. |
added 6 commits
January 4, 2016 07:07
|
One small thing I noticed regarding capitalization: For the first fenced code block in a file, the capitalization in the pre-specified language list seems to dominate what is typed by the user. For example, if I type "Fortran" as the language name the empty code block will be inserted as while I would have expected I won't have time to poke around the code until later today at the earliest, but I'll take a look. |
jrblevin
added a commit
that referenced
this pull request
Jan 4, 2016
completing-read gfm code languages
|
Yeah, check out my response in #59. |
|
For what it's worth, I didn't really notice any performance issues and I use helm as well. |
|
Cool! Guess my laptop is just slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38.
Does a few other things (although I swept the truly extraneous stuff to #53):
defcustoms for additional languages for gfm to complete outside of the given set, and also one to toggle whether or not to useelectric-backquoteat all.markdown-regex-gfm-code-block-open/closeinto a single regex, and uses that for highlighting. It was impossible to detect which line was supposed to contain a valid language otherwise.completing-readinput.markdown-replace-regexp-in-string.Concerns:
I use helm, so it's always somewhat slower to load than the default, but 335 candidates is proving to be pretty slow to bring up (and it's not the
cl-findcall, that only takes about .05 seconds once byte-compiled according to(benchmark)). So I was thinking many of the languages in linguist are pretty nonimportant, and I tried selecting about 100 of them which had names I could recognize, but that didn't seem to improve it for me at all, so I think it's just that helm'scompleting-readis slow. Let me know if you have those performance concerns and we can probably just triage the languages (although it'd have to be a pretty heavy triage since 100 candidates is still taking just over a third of a second to bring up the completions buffer).