-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-preferred case in GFM language names #59
Comments
Yeah, I didn't think about this too long before I implemented it. I wanted to avoid having miscapitalized versions of languages alongside the real ones, so I'm thinking let's just drop the attempt to squash capitalization and instead add all capitalizations of a language to the buffer-local corpus as they are added, and then return the unmodified language string that the user entered (as you would expect in this case). Do we want to |
I think I misread your comments/commit messages regarding capitalization. I thought you meant for it to do this already. In any case, I think it would be good to add all capitalizations used. I suppose it should ask for confirmation (once) for the sake of consistency within a file. |
Cool, so if the user enters a capitalization of a language it hasn't seen before, it'll ask to confirm (once) and add it to the corpus just as if it was a new language. I'll make a pr. |
For the first GFM fenced code block inserted in a file, the capitalization in the pre-specified language list seems to dominate what is typed by the user. For example, if one enters "Fortran" as the language name the empty code block will be inserted as
while one would have expected to instead see
(This was previously discussed in #54, but since that PR was merged I am just opening a new issue as a reminder.)
The text was updated successfully, but these errors were encountered: