Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout when plugin has a plugin-loaded dependency (regression in 0.27) #126

Closed
bpl opened this issue Oct 6, 2011 · 1 comment
Closed

Comments

@bpl
Copy link

bpl commented Oct 6, 2011

In RequireJS 0.26 it was possible to create a plugin that had a dependency to a plugin-loaded resource. This no longer works in 0.27 and results in Load timeout error whenever the outer plugin is used to load a resource. To clarify, the define callback for the outer plugin does get executed, but the load method is never called.

Here is a minimal test case that works in 0.26 but not in 0.27:

define(['text!test.txt'], function (test) {
    return {
        load: function (name, req, load, config) {
            load(test);
        }
    };
});
require(['pluginabove!dummy'], function (test) {
    // ...
});

For a more complete test case, please see Gist 1268616. I see this problem in both Firefox and Chrome.

@jrburke jrburke closed this as completed in a142581 Oct 7, 2011
@bpl
Copy link
Author

bpl commented Oct 8, 2011

Confirmed fixed. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants