Fix update bug on configurable product

The current code do an array_diff between old and new attributes and call a 'set' method. It seems to be a mistake. For configurable products, we just need to set newProductsIds as associated products.
jreinke · Jan 7, 2014 · dd672a2 · dd672a2
1 parent 457dacf
commit dd672a2
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/app/code/community/Bubble/Api/Helper/Catalog/Product.php b/app/code/community/Bubble/Api/Helper/Catalog/Product.php
@@ -25,13 +25,13 @@ public function associateProducts(Mage_Catalog_Model_Product $product, $simpleSk
 
             $usedProductIds = array_diff($newProductIds, $oldProductIds);
 
-            if (!empty($usedProductIds)) {
-                if ($product->isConfigurable()) {
-                    $this->_initConfigurableAttributesData($product, $usedProductIds, $priceChanges, $configurableAttributes);
-                } elseif ($product->isGrouped()) {
-                    $relations = array_fill_keys($usedProductIds, array('qty' => 0, 'position' => 0));
-                    $product->setGroupedLinkData($relations);
-                }
+            if (!empty($newProductIds) && $product->isConfigurable()) {
+                $this->_initConfigurableAttributesData($product, $newProductIds, $priceChanges, $configurableAttributes);
+            }
+
+            if (!empty($usedProductIds) && $product->isGrouped()) {
+                $relations = array_fill_keys($usedProductIds, array('qty' => 0, 'position' => 0));
+                $product->setGroupedLinkData($relations);
             }
         }