Skip to content

Commit

Permalink
[core] uploader validation errors should be ignored in assembly/chang…
Browse files Browse the repository at this point in the history
…elog mode
  • Loading branch information
aalmiray committed Feb 19, 2022
1 parent 31bd512 commit 4936d2d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ public static void validateArtifactory(JReleaserContext context, JReleaserContex
for (Map.Entry<String, Artifactory> e : artifactory.entrySet()) {
e.getValue().setName(e.getKey());
if (!mode.validateConfig()) {
e.getValue().setActive(Active.NEVER);
validateArtifactory(context, mode, e.getValue(), new Errors());
} else {
validateArtifactory(context, mode, e.getValue(), errors);
}
validateArtifactory(context, mode, e.getValue(), errors);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ public static void validateHttp(JReleaserContext context, JReleaserContext.Mode
for (Map.Entry<String, Http> e : http.entrySet()) {
e.getValue().setName(e.getKey());
if (!mode.validateConfig()) {
e.getValue().setActive(Active.NEVER);
validateHttp(context, mode, e.getValue(), new Errors());
} else {
validateHttp(context, mode, e.getValue(), errors);
}
validateHttp(context, mode, e.getValue(), errors);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ public static void validateS3(JReleaserContext context, JReleaserContext.Mode mo
for (Map.Entry<String, S3> e : s3.entrySet()) {
e.getValue().setName(e.getKey());
if (!mode.validateConfig()) {
continue;
validateS3(context, mode, e.getValue(), new Errors());
} else {
validateS3(context, mode, e.getValue(), errors);
}
validateS3(context, mode, e.getValue(), errors);
}
}

Expand Down

0 comments on commit 4936d2d

Please sign in to comment.