[release] username is no longer required for connecting to GitHub. Re…

…solves #262
jreleaser · Jul 4, 2021 · 6484c1b · 6484c1b
1 parent 416ffd9
commit 6484c1b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/Github.java b/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/Github.java
@@ -62,17 +62,15 @@ class Github {
     private final GitHub github;
 
     Github(JReleaserLogger logger,
-           String username,
-           String password,
+           String token,
            int connectTimeout,
            int readTimeout) throws IOException {
-        this(logger, ENDPOINT, username, password, connectTimeout, readTimeout);
+        this(logger, ENDPOINT, token, connectTimeout, readTimeout);
     }
 
     Github(JReleaserLogger logger,
            String endpoint,
-           String username,
-           String password,
+           String token,
            int connectTimeout,
            int readTimeout) throws IOException {
         this.logger = logger;
@@ -84,7 +82,7 @@ class Github {
         github = new GitHubBuilder()
             .withConnector(new JReleaserHttpConnector(connectTimeout, readTimeout))
             .withEndpoint(endpoint)
-            .withOAuthToken(password, username)
+            .withOAuthToken(token)
             .build();
     }
 

diff --git a/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/GithubReleaser.java b/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/GithubReleaser.java
@@ -57,7 +57,6 @@ public void release() throws ReleaseException {
             String changelog = context.getChangelog();
 
             Github api = new Github(context.getLogger(),
-                github.getResolvedUsername(),
                 github.getResolvedToken(),
                 github.getConnectTimeout(),
                 github.getReadTimeout());