Skip to content

Commit

Permalink
fix(assemble): Apply replaced platform to working directories and res…
Browse files Browse the repository at this point in the history
…olved image names

Fixes #1642
  • Loading branch information
aalmiray committed Apr 26, 2024
1 parent 17f36d7 commit a8c7f27
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ protected void doAssemble(TemplateContext props) throws AssemblerProcessingExcep
if (!targetJdk.isActiveAndSelected()) continue;

String platform = targetJdk.getPlatform();
String platformReplaced = assembler.getPlatform().applyReplacements(platform);
Path platformJarsDirectory = jarsDirectory.resolve(platform);
context.getLogger().debug(RB.$("assembler.copy.jars"), context.relativizeToBasedir(platformJarsDirectory));
copyJars(context, assembler, platformJarsDirectory, platform);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ protected void doAssemble(TemplateContext props) throws AssemblerProcessingExcep
}

String platform = packager.getJdk().getPlatform();
String platformReplaced = assembler.getPlatform().applyReplacements(platform);

Path assembleDirectory = props.get(Constants.KEY_DISTRIBUTION_ASSEMBLE_DIRECTORY);
Path workDirectory = assembleDirectory.resolve(WORK_DIRECTORY + "-" + platform);
Path workDirectory = assembleDirectory.resolve(WORK_DIRECTORY + "-" + platformReplaced);
Path inputsDirectory = workDirectory.resolve(INPUTS_DIRECTORY);
Path filesDirectory = inputsDirectory.resolve(FILES_DIRECTORY);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ protected void doAssemble(TemplateContext props) throws AssemblerProcessingExcep
context.getLogger().debug(RB.$("assembler.graal.graal"), graalVersion, graalPath.toAbsolutePath().toString());

String platform = assembler.getGraal().getPlatform();
String platformReplaced = assembler.getPlatform().applyReplacements(platform);
// copy jars to assembly
Path assembleDirectory = props.get(Constants.KEY_DISTRIBUTION_ASSEMBLE_DIRECTORY);
Path jarsDirectory = assembleDirectory.resolve(JARS_DIRECTORY);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ private static void validateJpackage(JReleaserContext context, Mode mode, Jpacka
JpackageAssembler.ApplicationPackage applicationPackage = assembler.getApplicationPackage();
packager.enable();

assembler.setPlatform(assembler.getPlatform().mergeValues(context.getModel().getPlatform()));

boolean hasJavaArchive = false;
if (isNotBlank(assembler.getJlink())) {
JlinkAssembler jlink = context.getModel().getAssemble().findJlink(assembler.getJlink());
Expand All @@ -108,9 +110,10 @@ private static void validateJpackage(JReleaserContext context, Mode mode, Jpacka
if (!context.isPlatformSelected(targetJdk)) continue;

String platform = targetJdk.getPlatform();
String platformReplaced = assembler.getPlatform().applyReplacements(platform);
Path path = baseOutputDirectory
.resolve("work-" + platform)
.resolve(imageName + "-" + platform)
.resolve(imageName + "-" + platformReplaced)
.toAbsolutePath();
candidateRuntimeImages.add(Artifact.of(path, platform));
}
Expand Down

0 comments on commit a8c7f27

Please sign in to comment.