Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skdman] Separation of concerns between packager and announcer #319

Closed
aalmiray opened this issue Jul 29, 2021 · 0 comments
Closed

[skdman] Separation of concerns between packager and announcer #319

aalmiray opened this issue Jul 29, 2021 · 0 comments
Assignees
Labels
BREAKING CHANGE enhancement New feature or request
Milestone

Comments

@aalmiray
Copy link
Member

The packager should only perform the following commands: release, release + default.
The announcer should only perform: announce.

Currently the packager supports these commands:

  • major: release + default + announce
  • minor: release + announce

The packager allows multiple candidates per project while the announcer allows a single one.

This change would require:

  • both packager and announcer be configured at the same time. currently they are mutually exclusive.
  • the announcer to collect all candidates configured per distribution and perform a release for each one.
  • if no packagers are configured then the announcer performs the same behavior it does right now: single candidate per project, with the choice of major or minor release.

Discussed with @maxandersen

@aalmiray aalmiray added enhancement New feature or request BREAKING CHANGE labels Jul 29, 2021
@aalmiray aalmiray self-assigned this Jul 29, 2021
@aalmiray aalmiray changed the title [skdman] Separation of concernes beween packager and announcer [skdman] Separation of concerns beween packager and announcer Jul 29, 2021
@aalmiray aalmiray changed the title [skdman] Separation of concerns beween packager and announcer [skdman] Separation of concerns between packager and announcer Jul 29, 2021
aalmiray added a commit to jreleaser/jreleaser.github.io that referenced this issue Jul 29, 2021
@aalmiray aalmiray added this to the v0.6.0 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant