Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jpackage] Can't use JFXCentral as application name #751

Closed
dlemmermann opened this issue Feb 14, 2022 · 1 comment
Closed

[jpackage] Can't use JFXCentral as application name #751

dlemmermann opened this issue Feb 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dlemmermann
Copy link

I currently can not use upper case "JFXCentral" as the application name as this will collide with naming conventions for linux packages. As a temporary workaround the application uses the name "jfxcentral" (all lower case).

@dlemmermann dlemmermann added the bug Something isn't working label Feb 14, 2022
@aalmiray
Copy link
Member

aalmiray commented Feb 14, 2022

The problem occurs on Linux when assembling a .deb installer

https://github.com/dlemmermann/jfxcentral/runs/5175175311?check_suite_focus=true

[INFO]    [jpackage] - packaging as deb
[DEBUG]   [jpackage] /home/runner/work/jfxcentral/jfxcentral/target/jdks/zulu17Linux/zulu17.30.15-ca-jdk17.0.1-linux_x64/bin/jpackage --type deb --dest /home/runner/work/jfxcentral/jfxcentral/target/jreleaser/assemble/JFXCentral/jpackage --input /home/runner/work/jfxcentral/jfxcentral/target/jreleaser/assemble/JFXCentral/jpackage/work-linux-x86_64/inputs/files --name JFXCentral --main-class com.dlsc.jfxcentral.JFXCentralAppLauncher --main-jar jfxcentral-1.0-SNAPSHOT.jar --runtime-image /home/runner/work/jfxcentral/jfxcentral/target/jreleaser/assemble/JFXCentral/jpackage/work-linux-x86_64/runtime-image --app-version 1.0.0 --vendor DLSC Software & Consulting GmbH --copyright Copyright © 2022 DLSC GmbH --description JFXCentral --java-options -Xmx1024m --resource-dir /home/runner/work/jfxcentral/jfxcentral/app/assets/linux --linux-package-name JFXCentral --linux-shortcut --linux-deb-maintainer dlemmermann@gmail.com --icon /home/runner/work/jfxcentral/jfxcentral/target/jreleaser/assemble/JFXCentral/jpackage/work-linux-x86_64/inputs/JFXCentral.png
[ERROR]   [jpackage] Bundler DEB Bundle failed because of java.lang.IllegalArgumentException: jdk.jpackage.internal.ConfigException: Invalid value "JFXCentral" for the bundle name.
[ERROR]   [jpackage] 
[INFO]  Writing output properties to target/jreleaser/output.properties
[ERROR] JReleaser failed after 22.477 s
org.jreleaser.util.JReleaserException: Unexpected error
	at org.jreleaser.engine.assemble.Assemblers.assemble(Assemblers.java:106)
	at org.jreleaser.engine.assemble.Assemblers.assemble(Assemblers.java:92)
	at org.jreleaser.workflow.AssembleWorkflowItem.invoke(AssembleWorkflowItem.java:30)
	at org.jreleaser.workflow.WorkflowImpl.execute(WorkflowImpl.java:66)
	at org.jreleaser.maven.plugin.JReleaserAssembleMojo.execute(JReleaserAssembleMojo.java:78)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:972)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:293)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:196)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.apache.maven.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:47)
	at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:156)
	at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:72)
Caused by: org.jreleaser.model.assembler.spi.AssemblerProcessingException: Unexpected error
	at org.jreleaser.assemblers.AbstractAssemblerProcessor.executeCommandCapturing(AbstractAssemblerProcessor.java:152)
	at org.jreleaser.assemblers.JpackageAssemblerProcessor.jpackage(JpackageAssemblerProcessor.java:246)
	at org.jreleaser.assemblers.JpackageAssemblerProcessor.doAssemble(JpackageAssemblerProcessor.java:98)
	at org.jreleaser.assemblers.AbstractJavaAssemblerProcessor.assemble(AbstractJavaAssemblerProcessor.java:82)
	at org.jreleaser.assemblers.JpackageAssemblerProcessor.assemble(JpackageAssemblerProcessor.java:55)
	at org.jreleaser.engine.assemble.DistributionAssembler.assemble(DistributionAssembler.java:62)
	at org.jreleaser.engine.assemble.Assemblers.assemble(Assemblers.java:102)
	... 33 more
Caused by: org.jreleaser.util.command.CommandException: Command execution error. exitValue = 1
	at org.jreleaser.assemblers.AbstractAssemblerProcessor.executeCommandCapturing(AbstractAssemblerProcessor.java:149)
	... 39 more

@aalmiray aalmiray changed the title [JPackage] Can't use JFXCentral as application name [jpackage] Can't use JFXCentral as application name Feb 14, 2022
@aalmiray aalmiray self-assigned this Feb 15, 2022
@aalmiray aalmiray added this to the v1.0.0-RC1 milestone Feb 15, 2022
aalmiray added a commit to jreleaser/jreleaser.github.io that referenced this issue Feb 15, 2022
aalmiray added a commit to jreleaser/jreleaser.github.io that referenced this issue Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants