Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Distribution artifacts are not included when releasing #938

Closed
2 of 4 tasks
aalmiray opened this issue Sep 1, 2022 · 1 comment
Closed
2 of 4 tasks

[core] Distribution artifacts are not included when releasing #938

aalmiray opened this issue Sep 1, 2022 · 1 comment
Assignees
@aalmiray
Labels
bug Something isn't working hackergarten Contributed at a Hackergarten event released Issue has been released
Milestone
v1.3.0

Comments

@aalmiray
Copy link
Member

aalmiray commented Sep 1, 2022

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem (link to git repository is ideal)
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. Create a project with a distribution such as https://github.com/aalmiray/app/
  2. Build the artifacts
  3. Perform a release

Expected Behaviour

A release with 2 binary assets

Actual Behaviour

No binary assets are found because the distribution is marked as disabled

trace.log

 distributions:
     app:
         enabled: false
         active: never
         type: JAVA_BINARY

Environment Information

  • Operating System: N/A
  • JReleaser Version: 1.3.0-SNAPSHOT
  • JDK Version: N/A
@aalmiray aalmiray added the bug Something isn't working label Sep 1, 2022
@aalmiray aalmiray added this to the v1.3.0 milestone Sep 1, 2022
@aalmiray aalmiray self-assigned this Sep 1, 2022
@aalmiray aalmiray added the hackergarten Contributed at a Hackergarten event label Sep 1, 2022
aalmiray added a commit that referenced this issue Oct 27, 2022
@aalmiray @TCarmine
fix(core): Validate distributions only when config is active. Fixes #938
e677e09 


Co-authored-by: TCarmine <kappa85t@hotmail.it>
@aalmiray
Copy link
Member Author

Released in v1.3.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.3.0

@aalmiray aalmiray added the released Issue has been released label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalmiray aalmiray

Labels
bug Something isn't working hackergarten Contributed at a Hackergarten event released Issue has been released
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
1 participant
@aalmiray