New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker] Cannot override repository name #951
Comments
The Also, the |
Not having it.
Aaah, that was is! Thanks for the pointer. Still playing around, and not having everything setup i probably would need, Just trying to understand why the jreleaser:package should not take the packages.docker.repo config? (as the error log suggests) Should have posted my complete POM, which would have made analyzing my problem easier - mea culpa. The <release>
<gitlab>
<owner>gitlabowner</owner>
<name>gitlabname</name>
</gitlab>
</release>
<distributions>
<myApp>
<stereotype>DESKTOP</stereotype>
<artifacts>
[...]
</artifacts>
<executable>
<windowsExtension>exe</windowsExtension>
</executable>
</myApp>
</distributions>
<packagers>
<docker>
<active>ALWAYS</active>
<continueOnError>true</continueOnError>
[...]
<repository>
<owner>dockerrepoowner</owner>
<name>dockerreponame</name>
<username>dockerrepousername</username>
</repository>
</docker>
</packagers> |
another fishy thing i cannot explain :/
pom.xml
<release>
<gitlab>
<owner>gitlabRepoOwner</owner>
<name>gitlabRepoName</name>
</gitlab>
</release>
<project>
<snapshot>
<label>${tier}</label>
</snapshot>
</project>
<packagers>
<docker>
<buildArg>--no-cache</buildArg>
[...]
<imageNames>
<imageName>imageowner/imagename:v${human.version}</imageName>
</imageNames>
</docker>
</packagers> When i build it that way, i get the log
And the above error of lowercase repo...bla.. <project>
<version>${human.version}</version>
</project> the output (and image) is now correct?!???
Something is really fishy whith the whole overriding... how can a dedicated project version behave THAT differrent?! |
This value |
uploaded a SSCCE here ;)
demonstrates kinda my setup. |
When displaying the configuration I get the following: docker:
enabled: true
active: always
templateDirectory: src/jreleaser/distributions/myapp/docker
useLocalArtifact: true
baseImage: max06net/base-gui:0.2.1-buster-slim
imageNames:
{{repoOwner}}/{{distributionName}}:{{tagName}} Which does not correspond with the configured setting <imageNames>
<imageName>imagenowner/imagename:v${human.version}</imageName>
</imageNames> The resolved value turns out to be the default. It looks like JReleaser does not set the appropriate value as expected. Filed #952 |
thx for taking care of this :) |
Released in v1.3.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.3.0 |
Task List
Steps to Reproduce
packagers.docker.repository.name
with any value (projectName in lowercase here)Expected Behaviour
value should be overridden as stated in docs, and build should succeed
Actual Behaviour
from trace;
the packagers config seem to be correct?
Sidenote:
Although the
docker.repository.owner
is correctly overridden (and visible in trace), the log above STILL shows my globalrelease.gitlab.owner
value.Environment Information
Please paste stacktraces from
[out|build|target]/jreleaser/trace.log
.The text was updated successfully, but these errors were encountered: