Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Update use of set-output in workflows #983

Closed
aalmiray opened this issue Oct 18, 2022 · 6 comments · Fixed by #985
Closed

[build] Update use of set-output in workflows #983

aalmiray opened this issue Oct 18, 2022 · 6 comments · Fixed by #985
Assignees
@himanshukandpal-28
Labels
build Hacktoberfest hacktoberfest-accepted released Issue has been released
Milestone
v1.3.0

Comments

@aalmiray
Copy link
Member

GitHub Actions will issue a warning when ::set-output is used. Switch to new syntax as suggested at https://hynek.me/til/set-output-deprecation-github-actions/
@aalmiray aalmiray added bug Something isn't working Hacktoberfest labels Oct 18, 2022
@himanshukandpal-28
Copy link
Contributor

himanshukandpal-28 commented Oct 18, 2022 •
edited

Hey folks shall I pick up the issue?

@aalmiray
Copy link
Member Author

Sure, go ahead. Please remember to follow our contribution guidelines. Thanks! 😅

@himanshukandpal-28 himanshukandpal-28 mentioned this issue Oct 18, 2022
Merged
3 tasks
@himanshukandpal-28
Copy link
Contributor

Hey @aalmiray raised the PR for the issue.

@aalmiray
Copy link
Member Author

@himanshukandpal-28 thanks! However PR #984 appears closed before merging. Was that intentional?

@himanshukandpal-28
Copy link
Contributor

himanshukandpal-28 commented Oct 18, 2022 •
edited

@himanshukandpal-28 thanks! However PR #984 appears closed before merging. Was that intentional?

Oh yes, actually I was testing then saw that these workflow only runs on main branch so rather than using side branch I moved my changes to main, #985 this is the one with all changes.

aalmiray pushed a commit that referenced this issue Oct 18, 2022
@himanshukandpal-28
build: Update use of set-output in workflows. Resolves #983
de36004
@aalmiray aalmiray added hacktoberfest-accepted build and removed bug Something isn't working labels Oct 18, 2022
@aalmiray aalmiray added this to the v1.3.0 milestone Oct 18, 2022
aalmiray pushed a commit that referenced this issue Oct 27, 2022
@himanshukandpal-28 @aalmiray
build: Update use of set-output in workflows. Resolves #983
d116148
@aalmiray aalmiray added the released Issue has been released label Oct 30, 2022
@aalmiray
Copy link
Member Author

Released in v1.3.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himanshukandpal-28 himanshukandpal-28

Labels
build Hacktoberfest hacktoberfest-accepted released Issue has been released
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

build: Update use of set-output in workflows himanshukandpal-28/jreleaser
2 participants
@aalmiray @himanshukandpal-28