Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Category titles should use one instead of multiple spaces. #597

Closed

Conversation

michael-simons
Copy link

See the title. If this has been done in purpose (two blanks), please just close it.

If you keep it two and someone wants to adapt their categories and one uses 1 space instead of two, 0.9.1 fails with:

JReleaser for project neo4j-migrations-parent has not been properly configured.: JReleaser has not been properly configured.
[ERROR] java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key validation_ares_missing
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2021

CLA assistant check
All committers have signed the CLA.

@aalmiray
Copy link
Member

I believe the 2 spaces were needed because otherwise the chosen emojis would appear next to the title. I'll look again if that's actually true.

Also the missing validation key has a typo: 'ares'. Need to fix that.

@aalmiray
Copy link
Member

Thank you @michael-simons. I think the underlying problem was that the category used the title for both identification and render. These two responsibilities have been split by #619 allowing you to change the rendering on your own project if needed.

The 2 spaces between emoji and text found in some of the categories are actually needed.

@aalmiray aalmiray closed this Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants