Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: projectNameCapitalized now handles hyphens as spaces #924

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Aug 29, 2022

Context

It fixes the projectNameCapitalized behavior

Checklist

@gastaldi

This comment was marked as outdated.

@gastaldi gastaldi marked this pull request as draft August 29, 2022 18:19
@gastaldi gastaldi marked this pull request as ready for review August 29, 2022 18:31
@aalmiray aalmiray added the bug Something isn't working label Aug 29, 2022
@aalmiray aalmiray added this to the v1.3.0 milestone Aug 29, 2022
@aalmiray
Copy link
Member

I thought org.jreleaser.util.StringUtils.getNaturalName would do the trick.

@gastaldi
Copy link
Contributor Author

I thought so too, but getNaturalName doesn't work with hyphens

@aalmiray
Copy link
Member

Got it. Good catch.

@aalmiray aalmiray merged commit 383eef4 into jreleaser:main Aug 30, 2022
@aalmiray
Copy link
Member

Thanks!

@gastaldi gastaldi deleted the projectNameCapitalized branch August 30, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Template name projectNameCapitalized does not replace hyphens by spaces
2 participants