fix(core): Generate filename for formula from packager config #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
roulpriya
changed the title
aalmiray
reviewed
Oct 13, 2022
There was a problem hiding this comment.
The use star imports is not recommended. Please review our contribution guidelines.
Also, I think the use of the chosen name transforming method should be reversed, that is, given a class name the result should be a hyphen separated name. The actual method to be used is getHyphenatedName().
roulpriya
changed the title
|
Hi, @aalmiray I have made the necessary changes. |
|
Thank you! 😁 |
|
Thanks @aalmiray |
aalmiray
pushed a commit
that referenced
this pull request
Oct 27, 2022
|
Released in v1.3.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #973
Context
Generate filename for formula from packager config
Checklist
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.