Rebase #1
Merged
Rebase #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add links for results and queries * Remove incorrect alt attributes * Smaller bottom marginat end of chapter content * Optimised images with calibre/image-actions * Increment page.css version as contains breaking changes Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix incorrect image * Optimised images with calibre/image-actions Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fixed index in desktop view * Highlight the current section being read in the index * Code cleanups + add Methodology * Use active style that was already defined * Better way of ensuring current element is in the viewport * Only set sticky when upgrading and also support prefers-reduced-motion * Move index highlighter up above interactive visuals * Add vendor prefix for Safari v12 * Code cleanup * Add back incorrectly removed overflow * Code refactor after review from @rviscomi * Remove index-scroller element and revert smooth scroller * Fix more code review issues * Extra comment on scrollIntoView
* Slightly better icons * Optimised images with calibre/image-actions Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Translation of ecommerce chapter to Japanese * delete line break * Fixed review * update alankent and samdutton's PR * delete unnecessary file * fix review
* Add reference link before chapter headings and figures * Fix markup errors * Add links to Methodology ad Accessibility Statement * Add example chapter * aAdd missing div for Acc statement * Optimised images with calibre/image-actions * Add link to authors section * Add classes to anchor_links * Support old link formats * Spacing fixes * Change link.png to SVG * Remove need for two classes * Add aria-hidden to link icon * Ensure no deletion of attributes * Review feedback * Fix changes no longer required * Remove link icon on mobile * Fix figures for some chapters * Tweak spacing a little * Move margin-left to better location * Remove style no longer required * Change chapter_links to <section> for conssitency * Fit mis-numbered image in Font chapter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Translation of cms chapter to Japanese * I have fixed review points
* translation of SEO chapter * Apply suggestions from code review Added before % sign Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com> * Apply suggestions from code review Co-Authored-By: Boris Schapira <borisschapira@gmail.com> * Update src/content/fr/2019/seo.md Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com> * Update src/content/fr/2019/seo.md Co-Authored-By: Boris Schapira <borisschapira@gmail.com> * Apply suggestions from code review Modification of many reviews Co-Authored-By: Boris Schapira <borisschapira@gmail.com> Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com> * modifications after the team reviews * other modifications * ymschaap bio * Non-breaking space before "%" * Typofix * Using back-tilts instead of french quotes * Typofix * Better description for AMP * labels of stats on featured chapter * No "alternate" in the original verbatin * Fix back-tilts * Update src/content/fr/2019/seo.md Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com> * Update src/content/fr/2019/seo.md Minor change Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com> * Update src/content/fr/2019/seo.md Organization schema type correct Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com> Co-authored-by: Barry Pollard <barry_pollard@hotmail.com> Co-authored-by: Boris Schapira <borisschapira@gmail.com>
* Markup chapter * CMS chapter * Caching chapter * Resource Hints chapter + small fixes * Missing space * Some fixing
* Fix bios * Typos
* Translation of featured_chapters to Japanese * fix review Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
* Translation of base.html to Japanese * Fixup URLs in bios * More bio fixes Co-authored-by: Barry <barry@tunetheweb.com>
* Translation of base_chapter to Japanese * Translation of index.html to Japanese * fix review
* Translation of fonts chapter to Japanese * fix web almanac * Adding changes for @ksakae1216 due to permission issues * Featured Chapters from @ksakae1216 * Fix markup bug for fonts chapter * Active fonts featured chapters Co-authored-by: Barry <barry@tunetheweb.com>
* Don't translate Web Almanac and HTTP Archive * fix review
* Translate "and" and show correct localized chapter name * Update src/templates/ja/2019/base.html * Allow Written by to be before or after for Japanese
* Refactor username parsing * Remove unnecessary exclusion * Show team mebers in the tooltip
* Reorganise HEAD to load CSS as quickly as possible * Remove unnecessary nonce
* Create CONTRIBUTING.md * Update README.md
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* 2020 Config Updates * Add two more analysts * Add some more people * Latest chapter order * Missing comma * Add line breaks * Revert "Add line breaks" This reverts commit 51fbd48.
* Test newline linting * Add newlines * Missed some newlines * Missed new line * Reset Action back to normal
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Make Contributor buttons accessible * Fix duplication of filter by block * Change to unpressed by default * Update src/templates/base/2019/contributors.html Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com> * Order by Team Translation Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…1056) * Fix bug where code block causes scrolling issues on mobile * Add newline for linter
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Sort by chapter number and refactor * Add legend and footnote * Move legend to column tooltip * Report team members and their chapters * Read tracked tasks from the reporting issue * Change delimiter Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com> * Prevent auto-mention for team members * Show contributors list only on demand * Add function to calculate statistics * Report chapter contributor statistics * Change summary text and make it bold Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
5% -> 50%
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…hapters (#1060) * hyphens and sorting * fix median * feedback * testing fixed syntax errors after testing * use "member" naming * case insensitive secondary sort of member names
* Change to A5 size for printing * Add cover * Fix cover * Remove unnecssary code * Fix some rems * Fix contributors and ass printer setting * Better alignment of cover * Finish cover * Make ebook resizable * Extra params * More rem-based styles * Linting issues * Update README * Regen ebooks * Handle large images * Merge cover and ebook into one template * Fix bad padding * Merge from main * Add Japanese version * Move title down on cover and simplify cover args * Better ebook instructions * Linting errors * Review feedback
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Report combined team size * Refactor stats calculation * Adjust tooltip as per new team formatting * Add new team type in the initialization * Change backticks to single quotes * Make union of chapter contributors unique
* Adding myself to the json :) * moving to alphabetical place
* update contributors * img dimensions * rm twitter from website
* Translate index.html to Spanish Left 'Web Almanac' like that as it is a noun. Happy to translate too if that's what has been done in other languages. * Capitalize 'Web' when used as a noun. * Add mcmd to 2020 contributors
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
rebase 0724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.