Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile parameter calculator #296

Open
crcrewso opened this issue May 20, 2020 · 8 comments
Open

Profile parameter calculator #296

crcrewso opened this issue May 20, 2020 · 8 comments

Comments

@crcrewso
Copy link
Contributor

crcrewso commented May 20, 2020

Is your feature request related to a problem? Please describe.
No issues - Functionality extension

Describe the solution you'd like

  • The ability to digest calibrated profile datasets from IC Profiler or equivalent device.
  • Calculate Flatness/Unflatness, symmetry, beam center, penumbra width, etc from calibrated profiles

Describe alternatives you've considered

  • Currently individual metrics are manually entered into QATrack.
  • Could Implement directly in QATrack
  • Could create an extension library

Additional context

  • I will be implement this functionality, if it's of interest to this community, my implementation could be pylinac based and pushed upstream. If there's no community interest then it makes sense to create the features directly in qatrack.

If the project maintainers feel this is of value please assign me.

@jrkerns
Copy link
Owner

jrkerns commented May 22, 2020

I wrote a file parser example here a little while ago. I think it would indeed be pretty useful to have such a parser. Feel free to make a pull request against pylinac. You are also free to do it on your own if you'd like. I'm a slow dinosaur and it takes me a while to get changes out so if you want it asap then probably release on your own, otherwise I'm happy to review and work on this. The good news is this should be a pretty basic implementation.

@crcrewso
Copy link
Contributor Author

I can see what you're doing there. It's a great start! My first guess for a layout is:

  • A reader class that selects the parser and returns the calibrated profiles for analysis in a consistent way, ie. inplane, crossplane, etc, based on metadata.
  • An analysis class that takes in pylinac profiles and the analysis method of interest.

Does this make sense? Would you rather a different organization method? If it does I'll work on getting the feature into a PR.

@jrkerns jrkerns mentioned this issue Apr 6, 2021
@jrkerns
Copy link
Owner

jrkerns commented Apr 6, 2021

Partially closed in #361. The integration with flatsym will happen after integrating #331

@crcrewso
Copy link
Contributor Author

crcrewso commented Apr 6, 2021

For testing, what test cases would you like to see added? I can provide (or generate) a few on our IC Profiler for Unit Testing

@jrkerns
Copy link
Owner

jrkerns commented Apr 7, 2021

That would be much appreciated. I have the typical data of open beams. IIRC there was a movie-like mode; I don't have any of that data. I also don't know if anything has changed in the firmware/file format since my data was taken (~2.5 years ago). Also in the file data it says a detector may be ignored. It's not clear if that's a user-directed thing, or something SNC does on the backend somewhere. If any of that rings a bell then that data would be appreciated to fill out the parser. Thanks!

@crcrewso
Copy link
Contributor Author

crcrewso commented Apr 7, 2021

I don't have movie mode or live mode, but, that's only really useful for beam alignment and the output of the first MU's

I'll get a dataset together with dose and array calibrations, flat fields, excluded detectors, etc. While I'm putting that data together would you like some PD's of asymmetric jaw fields? AAPM recommendation monthly test 8, CPQR ML14 or is this outside the scope of the flatness/symmetry module

@jrkerns
Copy link
Owner

jrkerns commented Apr 7, 2021 via email

@crcrewso
Copy link
Contributor Author

crcrewso commented Apr 7, 2021

Yes, I did mean EPID. I'll see about grabbing the same asymmetric MLC and jaw fields on EPID and IC Profiler. We've retired our profiler2 so I won't be able to go back that far.

jrkerns added a commit that referenced this issue Nov 10, 2023
RAM-3070 Add CIRS electron density phantom

Approved-by: Randy Taylor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants