-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catphan Modules without background_roi_settings result in nan background_median & background_std values #354
Comments
randlet
added a commit
to qatrackplus/pylinac
that referenced
this issue
Mar 31, 2021
…OI's present Resolves issue jrkerns#354
Also, somewhat related, should background_median = np.mean([roi.pixel_value for roi in self.background_rois.values()]) be background_mean = np.mean([roi.pixel_value for roi in self.background_rois.values()]) or background_median = np.median([roi.pixel_value for roi in self.background_rois.values()]) ? |
Quantitatively, mean or median doesn't make a big difference in this context, but for consistency, let's go with mean (middle). |
randlet
added a commit
to qatrackplus/pylinac
that referenced
this issue
May 13, 2021
…OI's present Resolves issue jrkerns#354
jrkerns
added a commit
that referenced
this issue
Mar 19, 2024
bump version Approved-by: Randy Taylor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
For Catphan modules without background_roi_settings (CTP486) the
background_median/background_std
get set to nan in _setup_rois because np.mean([]) == np.std([]) == nan. This throws RuntimeWarnings and / or FloatingPointError's. This nan gets propagated through to cnr calculations for the module roisTo Reproduce
The text was updated successfully, but these errors were encountered: