Set background_median and background_std to None when no background ROI's present #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OI's present Resolves issue jrkerns#354
jrkerns
reviewed
Mar 31, 2021
pylinac/ct.py
Outdated
| background_median = np.mean([roi.pixel_value for roi in self.background_rois.values()]) | ||
| background_std = np.std([roi.pixel_value for roi in self.background_rois.values()]) | ||
| if self.background_rois: | ||
| background_median = np.mean([roi.pixel_value for roi in self.background_rois.values()]) |
There was a problem hiding this comment.
change to mean per your own comment and all good
jrkerns
approved these changes
Mar 31, 2021
jrkerns
added a commit
that referenced
this pull request
Mar 25, 2024
WL refactor pre-step Approved-by: Randy Taylor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #354. Sets background_std & background_median to None when background rois aren't present.