[RBDyn/parsers] Parse mesh->scale as a vector #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the clang-format scripts since this is now handled by pre-commit
gergondet
force-pushed
the
topic/MeshScaleVector
branch
from
39c2c32
to
be3e9d8
Compare
This is an experiment rather than something that will be done on every repo where we have Cython bindings Without a tool to auto-format Cython files it's very cumbersome to implement after the fact
|
Hi @gergondet
Do developers need any steps to install and set up pre-commit, especially in an Ubuntu 20.04 environment? What is the standard installation procedure for pre-commit? |
|
Hi @mmurooka There's nothing to be done if you are using mc-rtc-superbuild as it's done automatically for you. Other wise:
|
|
Thanks for the explanation @gergondet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also updates the cmake submodule to use the more resilient Cython bindings generation.
It also sets a pre-commit configuration and removes the clang-format related scripts in favor of the automated pre-commit.ci usage