Reformat additional messages and finish centralizing exception handling #1424

wren · 2022-03-12T22:52:03Z

Checklist

I have read the contributing doc.
I have included a link to the relevant issue number.
I have checked to ensure there aren't other open pull requests
for the same issue.
I have written new tests for these changes, as needed.

cc jrnl-org#1024 jrnl-org#1141 - Stack traces are no longer shown to users unless the --debug flag is being used - Errors, warnings, and other messages contain color as needed - Converted error messages to Enum - Adds print_msg function to centralize output (this should replace all other output in other modules) Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>

* remove skip_editor test and tag * remove useless test * unskip blank input test * formatting * rename test so it doesn't overwrite other test * unskip some dayone tests that now work

Bumps [ipython](https://github.com/ipython/ipython) from 7.28.0 to 7.31.1. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@7.28.0...7.31.1) --- updated-dependencies: - dependency-name: ipython dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [asteval](https://github.com/newville/asteval) from 0.9.25 to 0.9.26. - [Release notes](https://github.com/newville/asteval/releases) - [Commits](newville/asteval@0.9.25...0.9.26) --- updated-dependencies: - dependency-name: asteval dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump black from 21.12b0 to 22.1.0 Bumps [black](https://github.com/psf/black) from 21.12b0 to 22.1.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/commits/22.1.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * Run make format Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>

…ricks" and "External Editors" from "Recipes" (jrnl-org#1332) * First draft of command line reference, mostly pulled from help screen * Add first draft of config file reference, mostly pulled from advanced.md * Clean up config file doc for readability * Add --config-file and remove examples from CLI reference * Add warning about time zone in timeformat * More small changes, and adding template config keyword * Cleaning up and re-ordering config file reference * Clean up reference and anything else from advanced documentation that can live elsewhere and linking to config file reference wherever config file is mentioned * Fix syntax highlighting in command line reference, clean up content a bit, include --diagnostic * Mention version config key * Apply minor changes suggested in PR review * Rename "recipes" to "Tips and Tricks", pull "External Editors" out of it into its own page, and redirect old recipes link to tips-and-tricks * Revert broken mkdocs-redirects usage from last commit

Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.2.5 to 7.0.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.2.5...7.0.0) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove Python 3.7 and 3.8 from github actions workflows * Update lockfile after running poetry update a couple times * Update poetry lock * Remove Python 3.7 and 3.8 from pyproject.toml and run poetry lock

* cleaned gitignore and add comments * removed colon for readbility * alphabetize files in sections Co-authored-by: nelnog <nel.nogales@gmail.com>

…eptions

wren and others added 30 commits February 5, 2022 16:05

format with black

5726bc6

add message to catch-all exception block

4157547

Unskip some tests (jrnl-org#1399)

9cb5630

* remove skip_editor test and tag * remove useless test * unskip blank input test * formatting * rename test so it doesn't overwrite other test * unskip some dayone tests that now work

Update changelog [ci skip]

896027e

Update changelog [ci skip]

054df35

Update changelog [ci skip]

275ce8b

Update changelog [ci skip]

8be1c2e

Add --co alias for --config-override (jrnl-org#1397)

7fd1a99

Add hash as a default tag symbol (jrnl-org#1398)

bb748db

Update changelog [ci skip]

7532f79

Increment version to v2.8.4-beta2

a1c4ca2

Update changelog [ci skip]

4761fee

Increment version to v2.8.4

299ddb2

Update changelog [ci skip]

b274fa4

Update changelog [ci skip]

44e56fb

Drop support for Python 3.7 and 3.8 (jrnl-org#1412)

c6fa22b

* Remove Python 3.7 and 3.8 from github actions workflows * Update lockfile after running poetry update a couple times * Update poetry lock * Remove Python 3.7 and 3.8 from pyproject.toml and run poetry lock

Update changelog [ci skip]

76d9bd4

Tidy up git ignore (jrnl-org#1414)

f5e6705

* cleaned gitignore and add comments * removed colon for readbility * alphabetize files in sections Co-authored-by: nelnog <nel.nogales@gmail.com>

fix behavior that was confusing pytest

c41f4fd

update test to match new message

ce84a7e

whitespace change

6c97792

clean up error for manually stopping the inline editor

66bdd06

udpate error to use new exception handling

2d8ffd1

move some exceptions and errors to the new exception handling

b907064

wren added 21 commits February 19, 2022 16:22

add line breaks to keyboard interrupt so it looks more like other exc…

7be9f20

…eptions

add handling for exceptions that happen earlier in the flow

e05257f

add new 'NothingToDelete' error to replace old behavior

94feae7

get rid of old exception

35cdd7b

add new exception handling to 'nothing saved to file' errors

e181302

move exception for no editor configured into new handling

782adef

move exception for no alt config to new handling

0b160aa

get rid of old exception handling for encrypted journal

101963b

Move error for too many wrong passwords into new handling

aa9343a

merge in develop

2051f04

fix merge errors

66ce8de

replace sys.exit call with new exception handling

6a4915c

replace sys.exit call with new exception handling

c5fc211

replace sys.exit call with new exception handling

548ac58

reformat with black

4a4a874

clean up old code

c7c6ecf

clean up old code

0d82315

clean up linting issue

d863d21

update uncaught exception for new handling

6915465

update test

132bd78

fix mangled lock file

3d28f97

micahellison approved these changes Mar 19, 2022

View reviewed changes

micahellison added the enhancement New feature or request label Mar 19, 2022

micahellison changed the title ~~Finish replacing sys.exit with new exception handling~~ Reformat additional messages and finish centralizing exception handling Mar 19, 2022

micahellison merged commit bc42f74 into jrnl-org:develop Mar 19, 2022

micahellison deleted the sys-exit-2-1141 branch March 19, 2022 19:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reformat additional messages and finish centralizing exception handling #1424

Reformat additional messages and finish centralizing exception handling #1424

wren commented Mar 12, 2022 •

edited

Loading

Reformat additional messages and finish centralizing exception handling #1424

Reformat additional messages and finish centralizing exception handling #1424

Conversation

wren commented Mar 12, 2022 • edited Loading

Checklist

wren commented Mar 12, 2022 •

edited

Loading