Add type hints #1614
Merged
Add type hints #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wren
reviewed
Nov 5, 2022
jrnl/DayOneJournal.py
Outdated
| @@ -210,7 +210,7 @@ def parse_editable_str(self, edited): | |||
| entries_from_editor = self._parse(edited) | |||
|
|
|||
| for entry in entries_from_editor: | |||
| entry = self._get_and_remove_uuid_from_entry(entry) | |||
| self._get_and_remove_uuid_from_entry(entry) | |||
There was a problem hiding this comment.
I know this is basically a no-op, but can we avoid anything other than type hint changes in this PR (to keep it separate from everything else)?
There was a problem hiding this comment.
Sure. Just for reference, there were two other changes not related to type hints:
wren
reviewed
Nov 5, 2022
micahellison
approved these changes
Nov 5, 2022
wren
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints to functions and methods
Uses Python 3.10 syntax
Waiting for #1611 and #1602 to be merged.
cc: #1608
Checklist
for the same issue.