Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flake8 and isort with ruff linter and add black --check to linting step #1763

Merged
merged 17 commits into from Jul 15, 2023
Merged

Replace flake8 and isort with ruff linter and add black --check to linting step #1763

merged 17 commits into from Jul 15, 2023

Commits on May 27, 2023

  1. Add ruff

    @micahellison
    micahellison committed May 27, 2023
    Configuration menu
    Copy the full SHA
    17d3040 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. Merge branch 'develop' into 1742-ruff

    @micahellison
    micahellison committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    2da4f91 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Add ruff config

    @micahellison
    micahellison committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    1ed2bd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Add ruff rules that look useful and are already passing

    @micahellison
    micahellison committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e7c7f54 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Add more ruff rules after talking with Jonathan

    @micahellison
    micahellison committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    53768bf View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Add line length exception for acceptably long indented line

    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    8062bf1 View commit details
    Browse the repository at this point in the history

  2. Resolve ruff line length 88 rule in args. Changing small lines but ad… 

    …ding a noqa ignore directive to longer lines that look best as they are. Their dedented length is still less than 88
    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    edd61b3 View commit details
    Browse the repository at this point in the history

  3. poe format

    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ece44c7 View commit details
    Browse the repository at this point in the history

  4. Resolve all remaining ruff line length errors

    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    71e1b38 View commit details
    Browse the repository at this point in the history

  5. Replace flake* and isort with ruff calls

    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    7423c59 View commit details
    Browse the repository at this point in the history

  6. Add black --check as final lint step. ruff catches most but not all b… 

    …lack formatting issues
    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    51d8369 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded flakeheaven setting

    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    5187ee5 View commit details
    Browse the repository at this point in the history

  8. Remove flake* and isort now that ruff is handling all their business

    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    a9a9ba4 View commit details
    Browse the repository at this point in the history

  9. Update pyproject, lockfile with latest version of ruff

    @micahellison
    micahellison committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b8f4a9d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Document each ruff rule with comment

    @micahellison
    micahellison committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    f247d07 View commit details
    Browse the repository at this point in the history

  2. Add black --version call before black --check

    @micahellison
    micahellison committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    0f12cc5 View commit details
    Browse the repository at this point in the history

  3. Remove extraneous period

    @micahellison
    micahellison committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    fd23c98 View commit details
    Browse the repository at this point in the history