Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 -- yaml export fixes, dayone fixes #349

Merged
merged 13 commits into from
May 6, 2015

Conversation

MinchinWeb
Copy link
Contributor

This pull request fixes/adds:

  • shlex.split on Windows (fixes Can't pass some options to vim #322, fixes shlex.split breaks on Windows paths #348)
  • CLI
    • if no editor is set, running jrnl allows you to create an entry, but no prompt was being given
    • colorizes warning and error messages throughout
  • improves Dayone handling:
    • moves to new-style date handling (variable length, square bracket enclosed)
  • improves YAML export handling
    • only increases headings by one level
    • includes the entry's UUID (if available) in the export
    • removes lines from the entry if they only list tags

@maebert
Copy link
Contributor

maebert commented May 6, 2015

dis gon b gud

Wow. So much goodness in here indeed. Merging it in now, thank you!

maebert added a commit that referenced this pull request May 6, 2015
2.0 -- yaml export fixes, dayone fixes
@maebert maebert merged commit 8a6563d into jrnl-org:2.0-rc1 May 6, 2015
@MinchinWeb MinchinWeb deleted the 2.0-yaml-export-fixes branch May 10, 2015 19:27
@MinchinWeb
Copy link
Contributor Author

@maebert , your responses get better and better! Glad to help

wren pushed a commit that referenced this pull request Apr 18, 2020
2.0 -- yaml export fixes, dayone fixes
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants