Fix crashing unicode Travis tests on Windows and fail build if Windows tests fail

[micahellison]

In Travis Windows machines, if any unicode is displayed in the console, the program crashes with the following error:

Exception UnicodeEncodeError: 'charmap' codec can't encode characters in position 6-69: character maps to <undefined>

Tests from PR #824 have verbose definitions for pretty print, which is full of interesting unicode characters. Unfortunately, not even the @skip_win directive can bypass this problem.

This can be reproduced on a local Windows machine by piping the output to a file, like so:

poetry run behave > testoutput.txt

The solution is to set the PYTHONIOENCODING variable to UTF-8 as documented here.

Now that these tests and all others are (hopefully) working in Windows, this PR also will fail the whole build if Windows tests fail.

Checklist

• The code change is tested and works locally.
• Tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• [n/a] Have you written new tests for your core changes, as applicable?

[wren]

🌬 🔥

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.