Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore emoji test #837

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Restore emoji test #837

merged 2 commits into from
Feb 9, 2020

Conversation

micahellison
Copy link
Member

This emoji test was removed a while back to allow Travis Windows builds to run. They were crashing before on this test, but eventually I found that it was just a problem with piping unicode and fixed it in PR #836.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [n/a] Have you written new tests for your core changes, as applicable?

@micahellison micahellison added the build Issues related to the build pipeline label Feb 8, 2020
wren
wren approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@wren wren merged commit 22994ef into jrnl-org:develop Feb 9, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline 🔒 Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micahellison @wren