Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up templates and issues #954

Merged
merged 2 commits into from
May 23, 2020
Merged

Conversation

wren
Copy link
Member

@wren wren commented May 17, 2020

This PR cleans up and standardizes some of our disparate templates. It is also
an attempt to make them a bit friendlier, and more succinct. It also adds a
message if anyone attemps to create a blank issue.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have you written new tests for these changes, as needed.
  • All tests pass.

be as precise as possible here, since more info will let us help you faster.
-->

### Other information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Information" should be capitalized

Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look great. Once that minor capitalization issue in bug_report.md is resolved I'll go ahead and approve.

@wren wren requested a review from micahellison May 23, 2020 22:21
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@micahellison micahellison merged commit 48afaf9 into jrnl-org:develop May 23, 2020
@wren wren added the build Issues related to the build pipeline label May 30, 2020
@wren wren deleted the issue-templates branch July 11, 2020 17:12
wren added a commit that referenced this pull request Jul 25, 2020
* clean up templates and issues
* fix some title-casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants