Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues on canva_palettes #78

Closed
Eluvias opened this issue Feb 20, 2017 · 3 comments
Closed

Issues on canva_palettes #78

Eluvias opened this issue Feb 20, 2017 · 3 comments

Comments

@Eluvias
Copy link

Eluvias commented Feb 20, 2017

The canva_palettes has two "Trendy and metropolitan" palettes; the second is empty and therefore
breaks the example.

tibble::enframe(canva_palettes) %>% filter(name == "Trendy and metropolitan")

In addition, there some typos when creating the canvas_df tibble.

I believe this is what you're after:

canva_df <- map2_df(canva_palettes, names(canva_palettes),
                    ~ tibble(color = .x, .id = seq_along(color), palette = .y))
@Eluvias
Copy link
Author

Eluvias commented Feb 20, 2017

Also in Elegant and sophisticated, the first HTML code contains 7 symbols instead of 6.

canva_palettes$`Elegant and sophisticated`[1]
[1] "#0b83c5d"

@Eluvias
Copy link
Author

Eluvias commented Feb 20, 2017

Here is the primary source of the issues -
http://makeadifferencewithdata.com/wp-content/uploads/2016/12/color-palettes.txt


<color-palette name="Trendy and metropolitan" type="regular" > 
<color>#488a99</color> 
<color>#dbae58</color> 
<color>#fbe9e7</color> 
<color>#b4b4b4</color> 
</color-palette>

<color-palette name="Trendy and metropolitan" type="regular" > 
<color>#</color> 
<color>#</color> 
<color>#</color> 
<color>#</color> 
</color-palette>


<color-palette name="Elegant and sophisticated" type="regular" > 
<color>#0b83c5d</color>
<color>#328cc1</color> 
<color>#d9b310</color> 
<color>#1d2731</color> 
</color-palette>

jrnold added a commit that referenced this issue Feb 20, 2017
From #78.

- bad HTML code in one element
- duplicated names
jrnold added a commit that referenced this issue Feb 20, 2017
Miscellaneous typos that weren't caught because I wrapped this in
dontrun for some reason.

From #78
@jrnold jrnold closed this as completed in 2f2f53e Feb 20, 2017
@jrnold
Copy link
Owner

jrnold commented Feb 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants