Update linter #170
Merged
Update linter #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- local variable 'classic' assigned but may not be used excel_themes.R Replace tidyverse package with specific packages - no visible global funtion definition for `set_names` - no visible global funtion definition for `flatten_chr` - no visible global funtion definition for `str_subset` libreoffice_palettes.R Replace tidyverse package with specific packages - no visible global funtion definition for `tibble` - local variable 'name' assigned but mau not be used tests/testthat/helper-utils.R Add testthat library explicitly
They cause unexpected symbol lint errors.
- Set line length to 120 - Ignore or fix remaining cases
Put spaces around all infix operators
Style the examples while ignoring those examples with `\dontrun`.
It was screwing up .lintr file which requires a newline, and not adding much benefit otherwise.
Indentation formatting is handled by styler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make linttarget