Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes #9

Merged
merged 2 commits into from
Apr 22, 2020
Merged

some fixes #9

merged 2 commits into from
Apr 22, 2020

Conversation

zhiics
Copy link
Collaborator

@zhiics zhiics commented Apr 18, 2020

Some fixes. I tested it locally test_vm and test_vm_serialization can all pass. CI should be happy now. Two other fixes. The first one is the serialization.

In the second one, I removed the last constant folding pass in memory pass to make test_vm_serialization pass (like MobileNet and ResNet). It actually reveals a problem/bug for VM because with this constant folding we will have:

let %1 = fn(p0, p1) {
  add(p0, p1)
}
%2 = (constant_1, constant_2)
%3 = (tensor1,)
invoke_tvm_op(%1, %2, %3)

Then compiler would get stuck here:

https://github.com/apache/incubator-tvm/blob/c936a81dab2b4b4b595d02153a6654b9d4e09cd5/src/relay/backend/vm/compiler.cc#L463

The problem reported by Luis is actually the same, which actually wasn't a bug introduced by the mentioned PR, but it would reveal this problem.

@zhiics zhiics force-pushed the coalesce-storage branch 2 times, most recently from 92ee7f5 to 3b3dc53 Compare April 18, 2020 16:45
@jroesch jroesch merged commit 36da8f2 into jroesch:coalesce-storage Apr 22, 2020
@zhiics zhiics deleted the coalesce-storage branch May 1, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants