Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] RSS compatibility #59

Closed
PhineasFreak opened this issue Feb 13, 2019 · 0 comments
Closed

[Bug] RSS compatibility #59

PhineasFreak opened this issue Feb 13, 2019 · 0 comments

Comments

@PhineasFreak
Copy link

It has come to my attention (in a rather...bad way) that WaypointManager breaks under RSS. The reason is that WaypointManager checks for the original CelestialBody names and not the final ones (edited by the Kopernicus cbNameLater parameter).

Some minimal changes that i did locally seem to fix most of the problems:

  1. Replacing b.name with b.bodyName
  2. Replacing w.celestialName with w.celestialBody.bodyName

One issue that remains is that the "KSC" waypoint (always visible by default) is listed under the "Sun" celestial (the actual waypoint is nowhere to be found though). After some digging around it looks like that it is populated by KSP itself (so it is most probably a bug with Kopernicus and not WaypointManager).

From a quick testing implementing the two above changes i was able to stop the "Couldn't find celestial body with name 'Kerbin'" log spam, open the WaypointManager interface and add/remove/edit/import waypoints (from external files).
@lamont-granquist lamont-granquist mentioned this issue May 25, 2019
Open
linuxgurugamer added a commit to linuxgurugamer/WaypointManager that referenced this issue Jun 10, 2020
@linuxgurugamer
Patch from github user @SumGuyTwitches:
7a8198c 
  fix kraken location off by 8 degrees
 Patch from Github user @taniwha:
  Use dateTimeFormatter for time period lengths

 Fixed RSS compatibility with changes listed in this issue on Github:
  jrossignol#59
linuxgurugamer added a commit to linuxgurugamer/WaypointManager that referenced this issue Jun 19, 2020
@linuxgurugamer
Adoption by LinuxGuruGamer
8e8b0a0 
 Added support for ToolbarController
 Added support for ClickThroughBlocker
 Patch from github user @SumGuyTwitches:
  fix kraken location off by 8 degrees
 Patch from Github user @taniwha:
  Use dateTimeFormatter for time period lengths

 Fixed RSS compatibility with changes listed in this issue on Github:
  jrossignol#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhineasFreak