Function to compute p-values from correlations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imathews
reviewed
Apr 27, 2021
| } else if (abs_r == 1.0 ) { | ||
| return 0.0 | ||
| } else { | ||
| return NaN |
There was a problem hiding this comment.
Should have test case to ensure that NaN is converted properly (use BQ IS_NAN method in test)
| -- Input: | ||
| -- r: correlation value, n : number of samples | ||
| -- Output: The p value of the correlation | ||
| CREATE OR REPLACE FUNCTION fn.corr_pvalue(r FLOAT64, n INT64 ) |
There was a problem hiding this comment.
BQ doesn't formally support INT64 inputs... I think this is fine, I imagine it'll just throw an error if the int can't be accurately represented in javascript. Maybe worth confirming this in a test case?
boaguilar
commented
May 18, 2021
| CREATE OR REPLACE FUNCTION fn.corr_pvalue(r FLOAT64, n INT64 ) | ||
| RETURNS FLOAT64 | ||
| LANGUAGE js AS """ | ||
| var abs_r = Math.abs(r) |
There was a problem hiding this comment.
Looks like this statement "Math.abs(r)" is generating errors in the testing process(E AssertionError: TypeError: "myproject.Math_test_local_test.abs" is not a function at UDF$1(FLOAT64, INT64))
; but this works fine in the console. Is this the right way to call the abs() function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.