Refactor back end and add front end DSL features #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgottlob
force-pushed
the
refactor
branch
5 times, most recently
from
0f79927
to
6c123b9
Compare
bgottlob
force-pushed
the
refactor
branch
2 times, most recently
from
0e3b9eb
to
11f6738
Compare
|
@bgottlob There's a bug in the new mysql module I posted. I'd comment on it in the PR, but for some reason I don't see that file in the PR (which is also concerning). Line 100 of lib/vidalia/mysql.rb should read |
Major changes: - Complete refactor of back end `Interface`, `Entity` (formerly `Object`), and `Element` code - Change `object` to `entity` in DSL - Add `open` and `close` methods for interface definition DSL for specifying how to open and close a database connection - Implicitly open and close database connection when calling Entity level methods - Remove old code and documentation that no longer applies after refactor - Switch to yard documentation instead of rdoc, document *most* code - Add `simplecov` for unit test code coverage reports - Add rubocop analysis and configuration, became *mostly* compliant - Update documentation
|
@jrotter I just rebased this branch off of your latest commit to master. The only conflict was the version bump in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Interface,Entity(formerlyObject), andElementcodeobjecttoentityin DSLopenandclosemethods for interface definition DSL forspecifying how to open and close a database connection
level methods
refactor
simplecovfor unit test code coverage reports