Skip to content

Commit

Permalink
Add additional point to driver versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@ajuckel
ajuckel committed Jan 19, 2013
1 parent 93e294a commit bd21d2c
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions jdbc-derby/lib/jdbc/derby.rb
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module Jdbc
module Derby
VERSION = "10.8.3.0"
VERSION = "10.8.3.0.1"

This comment has been minimized.

Sign in to view

Copy link
@kares

kares Jan 20, 2013

Member

no need to do this for derby since the jar was updated to 10.8.3.0 and has not been released yet ...

This comment has been minimized.

Sign in to view

Copy link
@ajuckel

ajuckel via email Jan 21, 2013

Author Contributor

This comment has been minimized.

Sign in to view

Copy link
@kares

kares Jan 21, 2013

Member

I disagree since there's no 10.8.3.0 release. a simple warning should not dictate us how we do driver updates ...
if you really wanted symmetry than a .1 release should be made out of the previous release 10.8.2.2 e.g. in a jdbc-derby-10.8.2.2 "maintenance" branch (due driver update on master). otherwise it just gets confusing esp. with long versioning such as Derby where one is not sure on first sight about the difference between : 10.8.3.1 and 10.8.3.0.1

This comment has been minimized.

Sign in to view

Copy link
@ajuckel

ajuckel Jan 21, 2013

Author Contributor

Yeah, I agree it's probably better to release 10.8.2.2.1. I am still a proponent of making the first release of jdbc-derby that includes jdbc driver version 10.8.3.0 will have a gem version of 10.8.3.0.0. The other option would be to break some degree of the linkage between jdbc driver version and jdbc-* gem version.

Also, it's worth noting that the core change that's bumping these version numbers isn't just an added warning. These jdbc-* versions, if the user does nothing, will load the underlying jdbc driver version automatically on load, and doesn't require the call to Jdbc::*.load_driver.

This comment has been minimized.

Sign in to view

Copy link
@kares

kares Jan 21, 2013

Member

yes, that's true but since we follow driver versions in gem versioning it's irrelevant if smt changed - the version can not clearly (semantically) reflect those changes - I understand your motivation about the added ".x" suffix for the next release just can't see how I'll benefit from it in the long term as a gem consumer (or if yet another "feature" is being added to the jdbc- gems I assume they won't have ".x.y" :)) ... thus I'm more inclined towards completely ignoring any "introduced" version tracking (in the long-term - I'm not against a .1 now) since it seems to be complicating things.

on the other hand I can live with it - but it would be nice if it did not require an irb mini-session to be run in once brain every-time he tries to figure out how the next version shall be increased ... thus maybe something like is more readable :

DRIVER_VERSION = "1.3.170".freeze
VERSION = DRIVER_VERSION + '.0'
...
"h2-#{DRIVER_VERSION}.jar"

def self.driver_jar
"derby-#{VERSION}.jar"
"derby-#{VERSION.split('.')[0..3].join('.')}.jar"
end

def self.load_driver(method = :load)
Expand Down
4 changes: 2 additions & 2 deletions jdbc-h2/lib/jdbc/h2.rb
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module Jdbc
module H2
VERSION = "1.3.170"
VERSION = "1.3.170.1"

def self.driver_jar
"h2-#{VERSION}.jar"
"h2-#{VERSION.split('.')[0..2].join('.')}.jar"
end

def self.load_driver(method = :load)
Expand Down
4 changes: 2 additions & 2 deletions jdbc-hsqldb/lib/jdbc/hsqldb.rb
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module Jdbc
module HSQLDB
VERSION = "2.2.9"
VERSION = "2.2.9.1"

def self.driver_jar
"hsqldb-#{VERSION}.jar"
"hsqldb-#{VERSION.split('.')[0..2].join('.')}.jar"
end

def self.load_driver(method = :load)
Expand Down
4 changes: 2 additions & 2 deletions jdbc-jtds/lib/jdbc/jtds.rb
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module Jdbc
module JTDS
VERSION = "1.3.0"
VERSION = "1.3.0.1"

def self.driver_jar
"jtds-#{VERSION}.jar"
"jtds-#{VERSION.split('.')[0..2].join('.')}.jar"
end

def self.load_driver(method = :load)
Expand Down
4 changes: 2 additions & 2 deletions jdbc-mysql/lib/jdbc/mysql.rb
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module Jdbc
module MySQL
VERSION = "5.1.22"
VERSION = "5.1.22.1"

def self.driver_jar
"mysql-connector-java-#{VERSION}.jar"
"mysql-connector-java-#{VERSION.split('.')[0..2].join('.')}.jar"
end

def self.load_driver(method = :load)
Expand Down
4 changes: 2 additions & 2 deletions jdbc-postgres/lib/jdbc/postgres.rb
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module Jdbc
module Postgres
VERSION = "9.2.1002"
VERSION = "9.2.1002.1"

def self.driver_jar
version_jdbc_version = VERSION.split( '.' )
version_jdbc_version = VERSION.split( '.' )[0..2]
version_jdbc_version << jdbc_version
'postgresql-%s.%s-%s.jdbc%d.jar' % version_jdbc_version
end
Expand Down
4 changes: 2 additions & 2 deletions jdbc-sqlite3/lib/jdbc/sqlite3.rb
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module Jdbc
module SQLite3
VERSION = "3.7.2"
VERSION = "3.7.2.1"

def self.driver_jar
"sqlite-jdbc-#{VERSION}.jar"
"sqlite-jdbc-#{VERSION.split('.')[0..2].join('.')}.jar"
end

def self.load_driver(method = :load)
Expand Down

2 comments on commit bd21d2c

@kares
Copy link
Member

@kares kares commented on bd21d2c Jan 20, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it would have been better to hard-code the jar VERSIONs ... e.g. "mysql-connector-java-5.1.22.jar"
(for our far future selves :)) since if we happen to forget to revert these and update the driver it might end up quite a bit confusing.

@ajuckel
Copy link
Contributor Author

@ajuckel ajuckel commented on bd21d2c Jan 21, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.