v1.2.2 does not support rails 3.2 explain feature #159

atambo · 2012-01-30T00:55:47Z

When trying to use the new rails 3.2 explain feature (http://weblog.rubyonrails.org/2011/12/6/what-s-new-in-edge-rails-explain) I get the following error:

undefined method `explain' for #<ActiveRecord::ConnectionAdapters::SQLite3Adapter:0x1139ba37>
activerecord (3.2.1) lib/active_record/explain.rb:65:in `exec_explain'
org/jruby/RubyKernel.java:1804:in `tap'
activerecord (3.2.1) lib/active_record/explain.rb:59:in `exec_explain'
org/jruby/RubyArray.java:2318:in `collect'
activerecord (3.2.1) lib/active_record/explain.rb:58:in `exec_explain'
activerecord (3.2.1) lib/active_record/relation.rb:146:in `explain'
app/controllers/home_controller.rb:48:in `index'

The text was updated successfully, but these errors were encountered:

nicksieger · 2012-01-30T01:08:42Z

Thanks, I didn't know about this yet. Patches appreciated from anyone for adding this feature.

boxofrad · 2012-02-03T09:18:01Z

Hope someone adds this soon!

For now i've just monkey patched over it in an initializer, so I can keep working:

module ActiveRecord::ConnectionAdapters
  class JdbcAdapter < AbstractAdapter
    def explain(*args)
      # Do nothing :'(
    end
  end
end

donv · 2012-03-04T22:50:14Z

How about this:

module ActiveRecord::ConnectionAdapters
  class JdbcAdapter < AbstractAdapter
    def explain(query, *binds)
      ActiveRecord::Base.connection.execute("EXPLAIN #{query}", 'EXPLAIN', binds)
    end
  end
end

boxofrad · 2012-03-05T13:08:55Z

@donv that might work as an interim solution for some RDBMSes but unfortunately not for me as i'm on SQL Server

:P

kimptoc · 2012-04-03T21:35:01Z

@boxofrad thanks - that let me progress, now things run and my couple of tests pass :)

arunagw · 2012-07-15T06:56:07Z

anyone got this working guys ?

codeodor · 2012-07-17T12:55:15Z

I've had it on my "to look into list" for a while to see if I could contribute something, but I just haven't made the time to go through it long enough to understand what's going on (with the hope that it could call back into Rails). It seems to me ar-jdbc-adapter ought to be able to reuse the SQL generated from the AR adapters for each of the DBs, but pass it through the jdbc interface instead.

lifted this code from the mysql2 gem and modified it to work in the JDBC gem. I've done testing under JRuby 1.6.7.2 with MySQL 5.1 and 5.5 with no issues. Github issue URL: jruby#159

cturner · 2012-07-17T19:34:16Z

Created pull request (#206) to patch this. I've tested under JRuby 1.6.7.2 with MySQL 5.1 and 5.5 with no issues.

I took the code that implements explain support in the mysql2 gem and slightly modified it to work here. I'm not happy with the block copying of the PrettyPrint class, but I couldn't figure out a way to leverage the code without doing that.

cturner · 2012-07-17T19:56:00Z

If this approach is acceptable to the maintainers I will be glad to implement explain support for SQLite and PostgreSQL as well.

pschambacher · 2012-12-12T16:46:51Z

I would also be interested in a solution to this for SQL Server, I just got hit by the issue :)

vysakh0 · 2013-01-03T19:18:08Z

undefined method `explain' for #ActiveRecord::ConnectionAdapters::PostgreSQLAdapter:0x521e980f Is there a fix for postgres as well??

elight · 2013-01-04T20:16:43Z

@vysakh0: Just encountered the same problem myself.

elight · 2013-01-04T20:38:35Z

So apparently @cturner's patch works just fine when copypasta'd right into the PostgreSQL JDBC driver as well...

Any objections to extracting his fix into a mixin and sharing it between the MySQL and PostgreSQL drivers?

ajuckel · 2013-01-04T20:41:05Z

A pull request which does so would certainly be welcome.
On Jan 4, 2013 2:38 PM, "Evan David Light" notifications@github.com wrote:

So apparently @cturner https://github.com/cturner's patch works just
fine with copypasta'd right into the PostgreSQL JDBC driver as well...

Any objections to extracting his fix into a mixin and sharing it between
the MySQL and PostgreSQL drivers?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/159#issuecomment-11898739.

elight · 2013-01-04T20:41:51Z

Noted. Thanks!

On Friday, January 4, 2013 at 3:41 PM, Anthony Juckel wrote:

A pull request which does so would certainly be welcome.
On Jan 4, 2013 2:38 PM, "Evan David Light" <notifications@github.com (mailto:notifications@github.com)> wrote:

So apparently @cturner https://github.com/cturner's patch works just
fine with copypasta'd right into the PostgreSQL JDBC driver as well...

Any objections to extracting his fix into a mixin and sharing it between
the MySQL and PostgreSQL drivers?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/159#issuecomment-11898739.

—
Reply to this email directly or view it on GitHub (#159 (comment)).

cturner · 2013-01-05T00:07:19Z

Good catch sir. I wasn't aware that Postgres had the same syntax and output. Are you going to convert this into a mixin or would you like me to work on it?

On Jan 4, 2013, at 15:41, Evan David Light notifications@github.com wrote:

Noted. Thanks!

On Friday, January 4, 2013 at 3:41 PM, Anthony Juckel wrote:

A pull request which does so would certainly be welcome.
On Jan 4, 2013 2:38 PM, "Evan David Light" <notifications@github.com (mailto:notifications@github.com)> wrote:

So apparently @cturner https://github.com/cturner's patch works just
fine with copypasta'd right into the PostgreSQL JDBC driver as well...

Any objections to extracting his fix into a mixin and sharing it between
the MySQL and PostgreSQL drivers?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/159#issuecomment-11898739.

—
Reply to this email directly or view it on GitHub (#159 (comment)).

—
Reply to this email directly or view it on GitHub.

elight · 2013-01-05T00:11:05Z

I started. Struggling with the LOAD_PATH when requiring the mixin.

On Friday, January 4, 2013, Chris Turner wrote:

Good catch sir. I wasn't aware that Postgres had the same syntax and
output. Are you going to convert this into a mixin or would you like me to
work on it?

On Jan 4, 2013, at 15:41, Evan David Light <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>
wrote:

Noted. Thanks!

On Friday, January 4, 2013 at 3:41 PM, Anthony Juckel wrote:

A pull request which does so would certainly be welcome.
On Jan 4, 2013 2:38 PM, "Evan David Light" <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>(mailto:
notifications@github.com <javascript:_e({}, 'cvml',
'notifications@github.com');>)> wrote:

So apparently @cturner https://github.com/cturner's patch works
just
fine with copypasta'd right into the PostgreSQL JDBC driver as
well...

Any objections to extracting his fix into a mixin and sharing it
between
the MySQL and PostgreSQL drivers?

—
Reply to this email directly or view it on GitHub<
https://github.com/jruby/activerecord-jdbc-adapter/issues/159#issuecomment-11898739>.

—
Reply to this email directly or view it on GitHub (
#159 (comment)).

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/159#issuecomment-11905788.

Evan Light
http://evan.tiggerpalace.com
@elight

ajuckel · 2013-01-05T01:04:20Z

Feel free to just throw the mixin into a shared file (like the jdbc adapter
from which they're derived). We can refactor it later if required.

elight · 2013-01-05T02:55:26Z

Deal.

On Friday, January 4, 2013, Anthony Juckel wrote:

Feel free to just throw the mixin into a shared file (like the jdbc
adapter
from which they're derived). We can refactor it later if required.
On Jan 4, 2013 6:11 PM, "Evan David Light" <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>
wrote:

I started. Struggling with the LOAD_PATH when requiring the mixin.

On Friday, January 4, 2013, Chris Turner wrote:

Good catch sir. I wasn't aware that Postgres had the same syntax and
output. Are you going to convert this into a mixin or would you like me
to
work on it?

On Jan 4, 2013, at 15:41, Evan David Light <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');><javascript:_e({},

'cvml', 'notifications@github.com <javascript:_e({}, 'cvml',
'notifications@github.com');>');>>

wrote:

Noted. Thanks!

On Friday, January 4, 2013 at 3:41 PM, Anthony Juckel wrote:

A pull request which does so would certainly be welcome.
On Jan 4, 2013 2:38 PM, "Evan David Light" <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');><javascript:_e({},

'cvml', 'notifications@github.com <javascript:_e({}, 'cvml',
'notifications@github.com');>');>(mailto:

notifications@github.com <javascript:_e({}, 'cvml',
'notifications@github.com');> <javascript:_e({}, 'cvml',
'notifications@github.com <javascript:_e({}, 'cvml',
'notifications@github.com');>');>)> wrote:

So apparently @cturner https://github.com/cturner's patch works
just
fine with copypasta'd right into the PostgreSQL JDBC driver as
well...

Any objections to extracting his fix into a mixin and sharing it
between
the MySQL and PostgreSQL drivers?

—
Reply to this email directly or view it on GitHub<

https://github.com/jruby/activerecord-jdbc-adapter/issues/159#issuecomment-11898739>.

—
Reply to this email directly or view it on GitHub (

#159 (comment)).

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub<

https://github.com/jruby/activerecord-jdbc-adapter/issues/159#issuecomment-11905788>.

Evan Light
http://evan.tiggerpalace.com
@elight

—
Reply to this email directly or view it on
GitHub<
https://github.com/jruby/activerecord-jdbc-adapter/issues/159#issuecomment-11905870>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/159#issuecomment-11906830.

Evan Light
http://evan.tiggerpalace.com
@elight

kares · 2013-01-16T18:30:51Z

on master explain for mysql/postgres and sqlite3

superchris · 2013-01-19T19:52:55Z

Just hit this trying to a Model.all using the derby ar jdbc adapter. Is there a more generic fix?

kares · 2013-01-19T20:00:09Z

@superchris unfortunately not as some DBs such as Derby or DB2 do not support simple "user-friendly" EXPLAIN ...
it's a bit harder to implement since you do need to query the explain data yourself ... PRs are very welcome

superchris · 2013-01-19T21:17:18Z

Sure, but it seems like there should be some way to stub this out with a no-op for databases that don't support this feature (or don't support it in an easily usable way)

elight · 2013-01-20T01:55:02Z

Disabling in in the app configuration isn't an option for you?

On Saturday, January 19, 2013 at 4:17 PM, Chris Nelson wrote:

Sure, but it seems like there should be some way to stub this out with a no-op for databases that don't support this feature (or don't support it in an easily usable way)

—
Reply to this email directly or view it on GitHub (#159 (comment)).

amazon123 · 2013-03-20T03:21:20Z

hit the issue again on jruby1.7.2, rails 3.2.11, activerecord-jdbc-adapter 1.2.8 on MSSQL (sqlserver)

codeodor · 2013-03-20T11:21:26Z

@amazon123 I don't know if it got fixed for SQL Server, so can't help with that problem, but I wanted to let you know there have been 2 more security releases to Rails since 3.2.11, in case you weren't aware.

See:

Fixed in Rails 3.2.12:
https://groups.google.com/forum/?fromgroups=#!topic/rubyonrails-security/AFBKNY7VSH8
https://groups.google.com/forum/?fromgroups=#!topic/rubyonrails-security/KtmwSbEpzrU

JSON Gem, fixed the same time as the above two:
https://groups.google.com/forum/?fromgroups=#!topic/rubyonrails-security/4_YvCpLzL58

Fixed in 3.2.13:
https://groups.google.com/forum/#!topic/ruby-security-ann/o0Dsdk2WrQ0
https://groups.google.com/forum/?fromgroups=#!topic/rubyonrails-security/4_QHo4BqnN8
https://groups.google.com/forum/?fromgroups=#!topic/rubyonrails-security/zAAU7vGTPvI
And especially important for JRuby users: https://groups.google.com/forum/?fromgroups=#!topic/rubyonrails-security/KZwsQbYsOiI

cturner mentioned this issue Dec 31, 2012

Updated MySQL JDBC adapter to support Rails 3.2 explain feature #206

Merged

kares closed this as completed Jan 16, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1.2.2 does not support rails 3.2 explain feature #159

v1.2.2 does not support rails 3.2 explain feature #159

atambo commented Jan 30, 2012

nicksieger commented Jan 30, 2012

boxofrad commented Feb 3, 2012

donv commented Mar 4, 2012

boxofrad commented Mar 5, 2012

kimptoc commented Apr 3, 2012

arunagw commented Jul 15, 2012

codeodor commented Jul 17, 2012

cturner commented Jul 17, 2012

cturner commented Jul 17, 2012

pschambacher commented Dec 12, 2012

vysakh0 commented Jan 3, 2013

elight commented Jan 4, 2013

elight commented Jan 4, 2013

ajuckel commented Jan 4, 2013

elight commented Jan 4, 2013

cturner commented Jan 5, 2013

elight commented Jan 5, 2013

ajuckel commented Jan 5, 2013

elight commented Jan 5, 2013

kares commented Jan 16, 2013

superchris commented Jan 19, 2013

kares commented Jan 19, 2013

superchris commented Jan 19, 2013

elight commented Jan 20, 2013

amazon123 commented Mar 20, 2013

codeodor commented Mar 20, 2013

v1.2.2 does not support rails 3.2 explain feature #159

v1.2.2 does not support rails 3.2 explain feature #159

Comments

atambo commented Jan 30, 2012

nicksieger commented Jan 30, 2012

boxofrad commented Feb 3, 2012

donv commented Mar 4, 2012

boxofrad commented Mar 5, 2012

kimptoc commented Apr 3, 2012

arunagw commented Jul 15, 2012

codeodor commented Jul 17, 2012

cturner commented Jul 17, 2012

cturner commented Jul 17, 2012

pschambacher commented Dec 12, 2012

vysakh0 commented Jan 3, 2013

elight commented Jan 4, 2013

elight commented Jan 4, 2013

ajuckel commented Jan 4, 2013

elight commented Jan 4, 2013

cturner commented Jan 5, 2013

elight commented Jan 5, 2013

ajuckel commented Jan 5, 2013

elight commented Jan 5, 2013

kares commented Jan 16, 2013

superchris commented Jan 19, 2013

kares commented Jan 19, 2013

superchris commented Jan 19, 2013

elight commented Jan 20, 2013

amazon123 commented Mar 20, 2013

codeodor commented Mar 20, 2013