Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[as400] Don't throw an exception if sequence number was defined #792

Merged
merged 1 commit into from
May 15, 2017

Conversation

rsov
Copy link
Contributor

@rsov rsov commented May 14, 2017

AS400 throws an exception if you try to run ADDRPYLE SEQNBR(9876) MSGID(CPA32B2) RPY('I') more than once per login. This was causing some issues in the testing environment

@kares kares merged commit d1cbbb8 into jruby:1-3-stable May 15, 2017
@kares kares added the db2 label May 15, 2017
@kares
Copy link
Member

kares commented May 15, 2017

btw. did you try https://github.com/pierrickrouxel/activerecord-jdbcas400-adapter ?
... supposed to be better than AR-JDBC. the idea was to move AS400 out of here - since we can not test it, thus it will always come last (not that anyone tests other DB2 systems much but I have tried and there's always a possibility to install the database compared to AS/400)

@rsov
Copy link
Contributor Author

rsov commented May 15, 2017

@kares Yes i did. It's a good idea to put all the as400 hacks into a separate gem. I could not get the AR 4.2 tests to run with it. They have a rake test:db2 command which runs the tests with db2 driver but nothing for the as400. Have to patch in something so it picks up on the as400 one

@kares
Copy link
Member

kares commented May 15, 2017

@rsov OK - was just worried that the as400 adapter might be a better suit for you.
no worries if you have tried it already.

@rsov
Copy link
Contributor Author

rsov commented May 15, 2017

@kares Thanks man! Will probably look into how to connect to the db2 side of the as400

@rsov rsov deleted the sequence_number_double branch August 3, 2017 13:49
kares added a commit that referenced this pull request Sep 25, 2017
* 1-3-stable:
  prepare for 1.3.24
  [as400] Fixed ordering when limit and offset present
  [postgres] limit driver version correctly since > 9.4.1206 might break
  limit postgres jdbc version since 9.4 has a breaking changes for AR-JDBC
  [db2] fixed issue with serialization not happening (#795)
  [test] transaction state being released on reconnect!/disconnect!
  reconnect!/disconnect! shall call super to reset cache/transaction state
  [oracle] some ~ enhanced adapter compatibility with configuration
  [mysql] support setting collation: xxx with config[:encoding] like AR 4.2
  [as400] Check if the exception thrown is a false-positive (#792)
  [as400] Added truncate functionality for DB2/AS400 (#793)
  [as400] Added DatabaseTasks for the as400 (#791)
  [test] [as400] Fixed issue when a GUI dialog popus and aks to log in (#790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants