[AR42][DB2] Fixed issue with serialization not happening #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @rsov ... as you probably already noticed your change effected other adapters and caused failures. |
|
@kares Yes, I've noticed it but didn't know what to do. Isolating the test is probably a good idea as it effects the db2 adapter only |
kares
added a commit
that referenced
this pull request
Sep 25, 2017
* 1-3-stable: prepare for 1.3.24 [as400] Fixed ordering when limit and offset present [postgres] limit driver version correctly since > 9.4.1206 might break limit postgres jdbc version since 9.4 has a breaking changes for AR-JDBC [db2] fixed issue with serialization not happening (#795) [test] transaction state being released on reconnect!/disconnect! reconnect!/disconnect! shall call super to reset cache/transaction state [oracle] some ~ enhanced adapter compatibility with configuration [mysql] support setting collation: xxx with config[:encoding] like AR 4.2 [as400] Check if the exception thrown is a false-positive (#792) [as400] Added truncate functionality for DB2/AS400 (#793) [as400] Added DatabaseTasks for the as400 (#791) [test] [as400] Fixed issue when a GUI dialog popus and aks to log in (#790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #725 bug
Added tests to confirm the behaviour
For some reason the the DB2 adapter's
quotemethod is not getting value after its been serialized. So we check the column isActiveRecord::Type::Serializedand then cast it for database