Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECDHE-RSA-AES128-GCM-SHA256 support #177

Conversation

mattbooks
Copy link

This adds support for ECDHE-RSA-AES128-GCM-SHA256. Many more are still missing,
but I am not familiar enough with openssl to go through and configure them.

This adds support for ECDHE-RSA-AES128-GCM-SHA256. Many more are still missing,
but I am not familiar enough with openssl to go through and configure them.
@betesh
Copy link

betesh commented Sep 4, 2019

@mattbooks I might have to fork this. Do you mind rebasing onto master?

@kares Anything holding up merging this?

@kares
Copy link
Member

kares commented Sep 5, 2019

a binary jopenssl.tar.gz file ...
and was hoping someone could review the full suite instead of adding ciphers 1-by-1

@betesh
Copy link

betesh commented Sep 5, 2019

a binary jopenssl.tar.gz file ...

I see one in the PR. Not sure I understand?

@mattbooks
Copy link
Author

It's been a while, but the tarball is probably a mistake and does not need to be included.

Updating the full suite is definitely a good idea but not something I'm able to do. This was a workaround to get me out of a bind, which I no longer am using.

@benissimo
Copy link

I've removed the tarball and rebased onto latest master here:
#185

@ThomasKoppensteiner
Copy link

What is the status of this PR?
Should it be closed and we continue with PR #185 ?

@mattbooks mattbooks closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants