Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.14 doesn't serve some static files (e.g. 404.html) with rails 4.1 #175

Closed
koffeinfrei opened this issue May 7, 2014 · 2 comments
Closed
Assignees

Comments

@koffeinfrei
Copy link

Certain static files as the *.html in the war root and images (precompiled asset pipeline files) aren't properly served. With CSS- and JS-Files there doesn't seem to be any issues though.

Jetty returns a correct HEAD 200 with the correct Content-Length but doesn't deliver the body, i.e. the files get delivered but don't have any content. E.g. for the 404.html the page is shown with blank content.

  • Warbler 1.4.2 with default settings for creating the war file.
  • Jetty 6.1.26-1ubuntu1
  • Ubuntu 14.04 lts
  • Java java-7-oracle / java-6-openjdk-amd64
  • Rails setting: config.serve_static_assets = false
  • Rails 4.1

Version 1.1.13.3 works.

@kares
Copy link
Member

kares commented Jun 20, 2014

confirming regression since 1.1.13.3 reproduced on Jetty 8.1 (interestingly Tomcat works) on Rails 3.2

  # Disable Rails's static asset server (Apache or nginx will already do this)
  config.serve_static_assets = false
  # Compress JavaScripts and CSS
  config.assets.compress = true
  # Don't fallback to assets pipeline if a precompiled asset is missed
  config.assets.compile = false
  # Generate digests for assets URLs
  config.assets.digest = true

@kares
Copy link
Member

kares commented Jun 20, 2014

regression seems to be caused by changing the ResponseCapture#isHandled implementation at : c83c65a#diff-9181274897bfb6cec39d09aca79e9cdeL168

kares added a commit that referenced this issue Jun 20, 2014
…d report as handled

- weird yet works with Tomcat as before and serves static content with Jetty right again
- make sure when asked and reported isHandled as truthy it stays (due the container)
- also do some internal cleanup - whole output swalowing should get a review ...

fixes #175
@kares kares closed this as completed Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants