Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files in axiom-types and descendants_tracker gems use 400 and 440 modes #1989

Closed
jeremyevans opened this issue Sep 19, 2014 · 4 comments
Closed

Files in axiom-types and descendants_tracker gems use 400 and 440 modes #1989

jeremyevans opened this issue Sep 19, 2014 · 4 comments
Milestone
JRuby 1.7.16

Comments

@jeremyevans
Copy link
Contributor

Issues in both upstream repos have been filed, with no response since May 23:

According to @headius, these gems are pulled in because they are transitive dependencies for jar-dependencies, which may not even need to be shipped.
@mkristian
Copy link
Member

may I ask where exactly the problem lies ?

yes, jruby-complete.jar does not contain those. jar-dependencies will install those gem on the fly when needed. the idea was to minimize the "download" when you first use jar-dependencies since even with ruby-maven already installed it will first download the half the internet. the second run is fast since the download is cached in the local maven repository.

the above gems are used for a pure ruby version of maven-model - let me see if jar-dependencies will work without those.

@jeremyevans
Copy link
Contributor Author

This isn't about jruby-complete.jar or using jar-dependencies. It's the simple fact that release tarballs should not contain files that are not group and world readable. Really, this should be fixed upstream, but since upstream is ignoring the issue, JRuby should work around this.

I only noticed the problem because I'm the JRuby port maintainer for OpenBSD, and the OpenBSD porting tools complain if you try to create a package that contains files that aren't group and world readable.

@mkristian mkristian added this to the JRuby 1.7.16 milestone Sep 20, 2014
mkristian added a commit that referenced this issue Sep 20, 2014
@mkristian
fix file permission on installed gems - fixes #1989 [skip ci]
4541de3
@mkristian
Copy link
Member

are the any requirements on directory permissions - if so please reopen the issue here or just leave a comment.

@jeremyevans
Copy link
Contributor Author

Looks like this is still a problem in 1.7.16:

ls -l jruby-1.7.16/lib/ruby/gems/shared/gems/descendants_tracker-0.0.4/TODO
-rw-r-----  1 jeremy  jeremy  0 Sep 25 12:33 jruby-1.7.16/lib/ruby/gems/shared/gems/descendants_tracker-0.0.4/TODO

mkristian added a commit that referenced this issue Sep 26, 2014
@mkristian
fixes #1989 at the right place this time
2cc85fc
enebo added a commit that referenced this issue Jul 19, 2021
@enebo
Reduce the hackery of the old fix of #1989.
00ddf5d 
lib/pom.rb was changing the permissions of all gem files to be 644.  This
caused other gems with binaries to lose their execute bit.  It also adds
time to the build during development.

The new code will only fix up the permissions of the unsupported gem
which demonstrates the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 1.7.16
Development

No branches or pull requests
2 participants
@jeremyevans @mkristian