Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripper is still 2.0 grammar and has not been updated for 2.2 changes #2427

Closed
enebo opened this Issue Jan 5, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@enebo
Copy link
Member

enebo commented Jan 5, 2015

Ripper is still 2.0 grammar and has not been updated for 2.2 changes

@enebo enebo added this to the JRuby 9.0.0.0 milestone Jan 5, 2015

@enebo

This comment has been minimized.

Copy link
Member Author

enebo commented Jun 26, 2015

I fixed this for rc1 actually but I will mark here so it shows up in some release notes.

@enebo enebo closed this Jun 26, 2015

yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015

Handle syntax error in Ripper
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.

yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015

Handle syntax error in Ripper
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.

yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015

Handle syntax error in Ripper
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.

yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015

Handle syntax error in Ripper
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.

myrridin pushed a commit to myrridin/rspec-core that referenced this issue Dec 11, 2015

Handle syntax error in Ripper
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.