Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date#next_year difference behvior with MRI #2867

Closed
gazay opened this issue Apr 22, 2015 · 7 comments
Closed

Date#next_year difference behvior with MRI #2867

gazay opened this issue Apr 22, 2015 · 7 comments
Labels
beginner core JRuby 1.7.x JRuby 9000 Rails ruby 2.0-2.2
Milestone
JRuby 1.7.22

Comments

@gazay
Copy link
Contributor

gazay commented Apr 22, 2015

bug from AS rails tests

Seems to related to #1769

# jruby master
irb(main):002:0> require 'date'
=> true
irb(main):003:0> Date.new(1581,10,10).next_year
=> #<Date: 1582-10-20 ((2299166j,0s,0n),+0s,2299161j)>

# ruby 2.2.2
irb(main):002:0> require 'date'
=> true
irb(main):003:0> Date.new(1581,10,10).next_year
=> #<Date: 1582-10-04 ((2299160j,0s,0n),+0s,2299161j)>
@headius headius added this to the 9.0.0.0.rc1 milestone Apr 22, 2015
@headius
Copy link
Member

headius commented Apr 22, 2015

This could be simple so I'm marking for beginners.

@headius headius added the Rails label Apr 22, 2015
@rnje-sghx
Copy link
Contributor

It seems like a good bug to get started.
@eregon had already posted a solution at #1769, but he also mentioned that it's likely to be fairly slow.
@headius Let me know if you have something like that in your mind.

rnje-sghx pushed a commit to rnje-sghx/jruby that referenced this issue Jun 29, 2015
[jruby#2867] modified Date#>> to take calendar reforms under consider…
c4e20e4 
…ation

- added tests for next month with calendar reform
- uses solution provided in jruby#1769 comments
- also fixes issues jruby#1769
@headius
Copy link
Member

headius commented Jul 2, 2015

I'm not concerned about the performance if we can get a fix in for this for JRuby 9k RC2. @eregon or @raeoks, can you make a PR so we can wrap this up?

@eregon
Copy link
Member

eregon commented Jul 3, 2015

I'll let @raeoks take care of it since he already worked on adding tests/specs.

rnje-sghx pushed a commit to rnje-sghx/jruby that referenced this issue Jul 8, 2015
[jruby#2867] moved add month with calendar reforms from rubytest to r…
9f3f630 
…ubyspec
@enebo enebo modified the milestones: JRuby 9.0.0.0.rc2, JRuby 9.0.0.0 Jul 9, 2015
@rnje-sghx rnje-sghx mentioned this issue Jul 20, 2015
Closed
eregon pushed a commit that referenced this issue Jul 21, 2015
@eregon
Add specs for Date#{<<,prev_year,next_year} around calendar reforms.
ec80a32 
* See #2867.
eregon pushed a commit that referenced this issue Jul 21, 2015
@eregon
[#2867] modified Date#>> to take calendar reforms under consideration
40e9140 
- added tests for next month with calendar reform
- uses solution provided in #1769 comments
- also fixes issues #1769
eregon pushed a commit to eregon/jruby that referenced this issue Jul 21, 2015
@eregon
[jruby#2867] modified Date#>> to take calendar reforms under consider…
3b83d09 
…ation

- added tests for next month with calendar reform
- uses solution provided in jruby#1769 comments
- also fixes issues jruby#1769
eregon pushed a commit to eregon/jruby that referenced this issue Jul 21, 2015
@eregon
Add specs for Date#{<<,prev_year,next_year} around calendar reforms.
d2a4cb2 
* See jruby#2867.
@eregon eregon mentioned this issue Jul 21, 2015
Merged
@kares kares added this to the JRuby 1.7.22 milestone Jul 21, 2015
@eregon
Copy link
Member

eregon commented Jul 23, 2015

Fixed by #3157 and #3091.

@eregon eregon closed this as completed Jul 23, 2015
@eregon
Copy link
Member

eregon commented Jul 23, 2015

Thanks @raeoks for your contribution and the specs!

@rnje-sghx
Copy link
Contributor

@eregon It's been a pleasure to work on JRuby. Next I'll move on to another beginner bug.

eregon pushed a commit to ruby/spec that referenced this issue Jul 27, 2015
@eregon
Add specs for Date#{<<,prev_year,next_year} around calendar reforms.
0133591 
* See jruby/jruby#2867.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner core JRuby 1.7.x JRuby 9000 Rails ruby 2.0-2.2
Projects
None yet
Milestone
JRuby 1.7.22
Development

No branches or pull requests
6 participants
@headius @enebo @gazay @kares @eregon @rnje-sghx