Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash keys should only be deduplicated for direct literal forms #3472

Closed
headius opened this issue Nov 19, 2015 · 0 comments
Closed

Hash keys should only be deduplicated for direct literal forms #3472

headius opened this issue Nov 19, 2015 · 0 comments

Comments

@headius
Copy link
Member

@headius headius commented Nov 19, 2015

In #3405 @tagomoris discovered that our Hash key deduplication for String was losing or modifying encodings. The base problem is that we were not considering encoding in our deduplicated String cache, sometimes returning a differently-encoded String if their contents match. I've fixed that in f6553cf but there's a further issue: to match MRI we should only be deduplicating String keys in a Hash when they are the direct, literal form, as shown below:

{"str" => 1} # "str" should be frozen and deduplicated
str2 = "str2"
{str2 => 1} # "str2" should be frozen and duplicated, not deduplicated

Other forms of simple inserting a String key into a Hash should also not deduplicate; our doing so is a bit overeager and led to discovering the bug in #3405.

We need to modify the IR compiler to make literal String keys to a literal Hash into FrozenString and modify the Hash-creation logic to simply use those deduplicated (and cached) frozen Strings as-is without re-attempting to dup them.

@headius headius added this to the JRuby 9.0.5.0 milestone Nov 19, 2015
@headius headius closed this in f3f0091 Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.